Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract robot constants to config file #330

Closed
2 tasks
ShaanGondalia opened this issue Sep 3, 2022 · 1 comment
Closed
2 tasks

Extract robot constants to config file #330

ShaanGondalia opened this issue Sep 3, 2022 · 1 comment
Assignees
Labels
controls Related to robot control
Milestone

Comments

@ShaanGondalia
Copy link
Contributor

ShaanGondalia commented Sep 3, 2022

Background

By definition, PID constants and robot kinematic values are specific to a robot. Storing these magic values in code conflicts with the "robot agnostic" architecture that Controls was originally designed with. These constants should be extracted to a config file. Controls already defines a structure for a config file describing a robot's thruster configuration. This structure should be extended to include robot constants (PID constants, maximum velocities, set-point ranges).

Tasks

  • Update config schema to support robot constants
  • Remove robot constants from position and velocity launch files
@ShaanGondalia ShaanGondalia added the controls Related to robot control label Sep 3, 2022
@ShaanGondalia ShaanGondalia added this to the Fall 2022 milestone Sep 3, 2022
@Brokemia Brokemia assigned Brokemia and caelum24 and unassigned Brokemia Sep 24, 2022
@Swahaha Swahaha self-assigned this Nov 5, 2022
@vedarshshah
Copy link
Member

Will be done as part of #454.

@vedarshshah vedarshshah reopened this Oct 26, 2023
@vedarshshah vedarshshah closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls Related to robot control
Projects
None yet
Development

No branches or pull requests

6 participants