Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider deprecating Base64Url #38

Open
damianh opened this issue Nov 12, 2024 · 1 comment
Open

Consider deprecating Base64Url #38

damianh opened this issue Nov 12, 2024 · 1 comment
Labels
area/identity-model Issues related to Identity Model impact/breaking The fix or change will be a breaking one

Comments

@damianh
Copy link
Member

damianh commented Nov 12, 2024

@joegoldman2 wrote:

.NET 9 adds support for Base64 Url (dotnet/runtime#1658). It's also compatible with .NET Standard 2.0. The class Base64Url should probably be deprecated in favor of the built-in support in the BCL.

IdentityModel/IdentityModel#580

@damianh damianh added the area/identity-model Issues related to Identity Model label Nov 12, 2024
@damianh damianh added the state/needs-triage Needs triaging by the maintainers label Nov 12, 2024
@damianh
Copy link
Member Author

damianh commented Nov 12, 2024

If we were to adopt this we would need to add a net9.0 target to IdentityModel and have some conditional package references.
Ref dotnet/runtime#1658 (comment) .

Resulting package references:

  • netstandard2.0 : System.Text.Json.8.0.5 and System.BCL.Memory.9.0.0
  • net8.0: System.BCL.Memory.9.0.0
  • net9.0: none

@damianh damianh added impact/breaking The fix or change will be a breaking one and removed state/needs-triage Needs triaging by the maintainers labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/identity-model Issues related to Identity Model impact/breaking The fix or change will be a breaking one
Projects
None yet
Development

No branches or pull requests

1 participant