Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite #5

Open
9 tasks
lucyelle opened this issue Sep 22, 2024 · 1 comment
Open
9 tasks

Rewrite #5

lucyelle opened this issue Sep 22, 2024 · 1 comment

Comments

@lucyelle
Copy link
Collaborator

The current state of the code is not very maintainable and doesn't follow good React practices. Since we are planning to drop the compiler API usage and the C# component as a whole, we might as well start with a refactor where we end up with the basic editor interfacing with the compiler through CLI.

Steps to refactor:

  • Scaffold empty React project
  • Integrate Monaco
  • Integrate Golden Layout to have two basic tabs, one being the editor
  • Integrate the terminal emulator
  • Call the Draco compiler from CLI
  • Reintegrate workers to be able to cancel ongoing compilation
  • Integrate NuGet API to retrieve compiler versions
  • Implement a cache to cache used compiler versions
  • Reintegrate sharable URL feature
@Kuinox
Copy link
Member

Kuinox commented Sep 22, 2024

A few things:

doesn't follow good React practices

There isn't any react code currently, I also don't see why using it, since we use golden layout, the few time we dynamically create html are:

I would put the sharable URL higher, also take care of backcompat to not kill existing URLs.
iirc there is a version embedded in it so it can evolve.

The hardest thing in the list is probably retrieve the nuget api, since there is no nuget client in js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants