Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The lump repeat marker is a mis-feature and should be removed #61

Open
andwj opened this issue Aug 23, 2018 · 1 comment
Open

The lump repeat marker is a mis-feature and should be removed #61

andwj opened this issue Aug 23, 2018 · 1 comment

Comments

@andwj
Copy link
Contributor

andwj commented Aug 23, 2018

Most sections in a wadinfo.txt file support a * at the end of an entry, and it means the current entry will simply be a copy of the previous one, using the same offset and length in the output wad file. Seems the idea is to save space if you have a resource that is repeated.

The main exception is the [LEVELS] section, which currently ignores the repeat marker.

I have quite a lot of wadinfo files on my computer (over 100), including from most of the IWADS, and only two of them contain this repeat marker: the Heretic iwad and the Hexen iwad, used three times in each one, and all of them are zero-length lumps.

So I think this is actually a mis-feature with very low utility, and Deutex would be better without it. The code to support it really hampers understanding of the composition code in compose.c. It also makes it harder to add support for new sections in Deutex, e.g. I haven't coded support for it in the TX_START stuff yet.

@fragglet
Copy link
Contributor

Interesting, I didn't know that deutex had this feature. Note that you can use wadptr to get the same result automatically without any special configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants