Skip to content
This repository has been archived by the owner on Nov 4, 2020. It is now read-only.

feature request: allow custom jupyter command #125

Open
chrstphrchvz opened this issue Jul 16, 2018 · 0 comments
Open

feature request: allow custom jupyter command #125

chrstphrchvz opened this issue Jul 16, 2018 · 0 comments

Comments

@chrstphrchvz
Copy link

Currently the extension is harcoded to run the command jupyter notebook:

private startJupyterNotebookInTerminal(startupFolder: string, args: string[]) {
this.notebookOutputChannel.appendLine('Starting Jupyter Notebook');
this.notebookOutputChannel.appendLine('jupyter ' + ['notebook'].concat(args).join(' '));
return spanwPythonFile('jupyter', ['notebook'].concat(args), startupFolder)
.then(proc => {
this.proc = proc;
this.proc.stderr.on('data', data => {
this.notebookOutputChannel.append(data.toString());
});
});
}

It would be desirable to instead use jupyter command by default while allowing a custom jupyter command as a user/workspace setting, in case one with a different name or PATH is needed. This is a feature which many other extensions tend to offer for any system commands they use.

(I'm using jupyter installed from MacPorts, which at the moment only provides renamed commands like jupyter-3.6 commands to prevent conflicts between multiple versions—one for each Python version. There is likely a way to allow selecting one of them to provide an exact jupyter command, but that still hasn't been added after quite some time: cf. https://trac.macports.org/ticket/51529.)

chrstphrchvz added a commit to chrstphrchvz/vscodeJupyter that referenced this issue Jul 17, 2018
chrstphrchvz added a commit to chrstphrchvz/vscodeJupyter that referenced this issue Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant