Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate each app into separate git repositories #431

Open
PaiJi opened this issue Sep 9, 2024 · 0 comments
Open

Isolate each app into separate git repositories #431

PaiJi opened this issue Sep 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@PaiJi
Copy link
Contributor

PaiJi commented Sep 9, 2024

What problem will this feature address?

When i work on #421 , CI encountered some issues with TypeScript types, which were later found to be due to specific versions of @types/react and @types/react-dom. However, forcing a regeneration of pnpm-lock.yaml would break tests for other applications within the same workspace. In this case, app/dokploy's tests were affected.

I tried to upgrade only this dependency, but due to the nature of the workspace, all sub-project dependencies are intertwined. The CI still refused to work, so I had no choice but to add a resolutions in the package.json at the workspace root to force all dependencies to use specified versions. I feel this approach is quite problematic.

If our various projects are in separate git repositories, we can freely modify the dependencies of less critical projects without worrying about inadvertently breaking our most core and essential product.

Describe the solution you'd like

Isolate each app into separate git repositories

Describe alternatives you've considered

None.

Additional context

No response

@PaiJi PaiJi added the enhancement New feature or request label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant