Force urls to have a trailing slash

[RobbieTheWagner]

I have been working on converting my app to use prember, and I had a need to force trailing slashes. I am extending the router-scroll location type to achieve this. Would there be interest in adding support here directly with a flag to enable?

import EmberRouterScroll from 'ember-router-scroll/locations/router-scroll';

export default EmberRouterScroll.extend({
  formatURL() {
    let url = this._super(...arguments);

    if (url.includes('#')) {
      return url.replace(/([^/])#(.*)/, '$1/#$2');
    } else {
      return url.replace(/\/?$/, '/');
    }
  }
});

[yowainwright]

@rwwagner90 I could see scenarios where this would cause issues.

What is the benefit?

Also, if this is a feature that the community wants, using includes would probably cause issues.

---

• Array.includes documentation should mention ember-runtime-enumerable-includes flag emberjs/ember.js#14322

[RobbieTheWagner]

@yowainwright the benefit is to require slashes in urls for static sites. I'm using prember, which needed this tweak.

includes is totally fine and supported in node 4+. Ember is even dropping node 4 at the end of April.

[lougreenwood]

I've just come across this issue too, @rwwagner90 👍

@yowainwright for context, the issue for me is an SEO one - omitting the trailing slash means that Google isn't discovering the actual page.

[RobbieTheWagner]

Ember has now dropped node 4 support as well, so this should be good to go. If you guys are open to it, I can open a PR.

[snewcomer]

@rwwagner90 I'm guessing this is a global flag?

[RobbieTheWagner]

@snewcomer yeah, would need a way to turn it off and on

[RobbieTheWagner]

@snewcomer any thoughts on if we want to implement this? At the very least, we could document how to do this in the README.