Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any reason scrollElement needs an ID? #77

Open
samselikoff opened this issue Oct 21, 2017 · 5 comments
Open

Any reason scrollElement needs an ID? #77

samselikoff opened this issue Oct 21, 2017 · 5 comments
Labels
enhancement

Comments

@samselikoff
Copy link
Contributor

Could we change scrollElement to accept any CSS selector, like a class?
@briangonzalez
Copy link
Contributor

Yes, absolutely @samselikoff. Not sure that is the way it is. PR's welcomed.

@yowainwright
Copy link
Contributor

It seems this issue was fixed.

@samselikoff
Copy link
Contributor Author

@yowainwright I believe this is still an issue: https://github.com/dollarshaveclub/ember-router-scroll/blob/master/addon/services/router-scroll.js#L54

I'd like scrollElement to be able to be any css selector (not targetElement)

Mind reopening?

@yowainwright yowainwright reopened this Nov 8, 2018
@yowainwright
Copy link
Contributor

@samselikoff do you have time to submit a PR with this update? Thank you.

Thanks for articulating the issue as well.

@samselikoff
Copy link
Contributor Author

I don't at the moment but let's leave this open for now, may be able to carve out some time soon-ish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@briangonzalez @yowainwright @samselikoff