Prevents apps from stubbing router service in unit tests

[ef4]

This addon eagerly instantiates its service in an instance-initializer:

ember-router-scroll/addon/instance-initializers/ember-router-scroll.js

Line 3 in 2f17728

appInstance.lookup('service:router-scroll');

Which also eagerly instantiates the router service:

ember-router-scroll/addon/services/router-scroll.js

Line 72 in 2f17728

@service router;

But that means it's impossible to write a unit test that stubs the router service, because setupContext from @ember/test-hepers (which is what backs setupTest from 'ember-qunit') will run this initializer before users have a chance to register any overrides.

So if people have unit tests against a stubbed router service, and then they add this addon, those tests break.

[mupkoo]

One thing that you can do to go around this problem is to unregister the router service, before registering your mock

this.owner.unregister('service:router');
this.owner.register('service:router', class extends Service {});