NSF Driver and Export Fixes #262

Gumball2415 · 2024-02-17T17:17:12Z

This pull request aims to fix various bugs regarding NSF driver export and execution.

This pull request improves upon and supercedes #156.

Changes in this PR:

Major export refactoring
- Use CCompiler pointer for writing ASM export title
- Decouple NSFDRV header from driver data
- Add NSF stub file for .asm export
- Fix assembly period table export
- Fix VRC7 period table assembly export
- Implement "glob" multichip assembly export
- Ignore invalid pattern data upon NSF export
  - Fixes NSF Export Issues in 0.5.0.1 #215
- Specify what parts of pattern data are invalid
- Differentiate between error and warning colors
- Account for HOLD_INSTRUMENT in pattern checking
- Specify overflow in driver bank allocation
- Refactor compressed mode size calculation
- Include N163 period table in .asm export
- Declare alignment for first DPCM sample in assembly export
- Remove hardcoded bank references in assembly song header
- Implement bankswitched assembly config exports
- Add bank 0 for nonbankswitching config
- Refactor NSFe metadata generation
- Fix NES ROM export data alignment
  - Fixes NROM iNES Export: Fix launcher kernel #278
- Fix DPCM segment start address in nonbankswitching assembly
- Refactor multifile export
NSF driver fixes
- Fix N163 instrument load clobbering Kxx state
  - Fixes NSF driver: N163 instrument load clobbering Kxx state #224
  - Fixes NSF export sometimes skips some N163 channels #260
  - Iterates on Update NSF Driver and NSF-related things #156
- Fix S5B init clobbering Kxx state
- Write carrier frequency regardless of Kxx state
  - Fixes Issue with FDS modulation not being exported to NSF #196
- Fix phase reset behavior
- Refactor phase reset code
- Update effect bytecodes in row skip handling
  - Fixes Dxx does not behave properly in NSF export (under specific circumstances) #183
- Handle Gxx delay commands in both row and frame transitions
  - Fixes NSF export effects state corruption? #207
- Fix S5B instrument duty envelopes
  - Fixes S5B envelopes broken on NSF export #267
- Clamp pitch and hi-pitch envelope period results
- Enable pitch sliding in linear pitch mode
- Implement linear pitch period limit
- Correct linear pitch calculation sequence
Internal fixes
- Fix debug constexpr
In-beta issue ((dev branch) N163's pitch slide speed is slower in NSF export compared to Famitracker playback #276):
- Refactor Pitch/HiPitch bend logic
- Apply N163 slide shift if linear pitch is disabled
  - Addresses (dev branch) N163's pitch slide speed is slower in NSF export compared to Famitracker playback #276
- Refactor period limit subroutine
  - Fixes (dev branch) N163's pitch slide speed is slower in NSF export compared to Famitracker playback #276.
- Fix N163 portamento shift in linear period
  - Fixes (dev branch) N163's pitch slide speed is slower in NSF export compared to Famitracker playback #276

Leafuw, nyanpasu64, and Zeta, thank you for your help!

Fixes #224. Fixes #260. Iterates upon #156.

Fixes #256. Fixes #246. Fixes #215.

Fixes #196.

Fixes #183.

...transitions Fixes #207.

Fixes #215.

Refactor compressed mode calculation

Differentiate between error and warning colors

Fixes #267.

Thanks, Zeta!

Gumball2415 · 2024-06-13T06:27:14Z

TODO: fix linear pitch pitch sequences
TODO: fix filename handling with two filetype extensions

Gumball2415 · 2024-06-20T15:20:58Z

TODO: fix asm export DPCM start address issue with beep.dnm

Fixes #278.

Addresses #276.

- Correct linear pitch calculation sequence

Fixes #276.

Gumball2415 · 2024-07-20T10:04:52Z

TODO: fix linear pitch pitch sequences

fixed in 4ce047d

TODO: fix asm export DPCM start address issue with beep.dnm

fixed in fa05bd9

Fixes #276.

Thanks, Leafuw and nyanpasu64!

Gumball2415 added 5 commits February 1, 2024 18:46

Use CCompiler pointer for writing ASM export title

a7487a0

Decouple NSFDRV header from driver data

febc65e

Refactor auxiliary assembly data generation

72148d6

Add NSF stub file for .asm export

1f9e366

Fix assembly period table export

b52993e

Gumball2415 force-pushed the app-emu-module-nsf_driver-dev branch from 9f54952 to d5a976c Compare February 17, 2024 18:28

Gumball2415 added 16 commits March 23, 2024 01:47

Fix N163 instrument load clobbering Kxx state

861f682

Fixes #224. Fixes #260. Iterates upon #156.

Fix VRC7 period table assembly export

0954020

Fix S5B init clobbering Kxx state

31075be

Fixes #256. Fixes #246. Fixes #215.

Implement "glob" multichip assembly export

e67e701

Write carrier frequency regardless of Kxx state

eeb7835

Fixes #196.

Fix debug constexpr

e390204

Update effect bytecodes in row skip handling

3c08177

Fixes #183.

Fix NSF driver phase reset behavior

b57faeb

Handle Gxx delay commands in both row and frame...

3ef2be3

...transitions Fixes #207.

Ignore invalid pattern data upon NSF export

c0d46f5

Fixes #215.

Specify overflow in driver bank allocation

9abc231

Refactor compressed mode calculation

Specify what parts of pattern data are invalid

716f8e6

Differentiate between error and warning colors

Fix S5B instrument duty envelopes

04f6190

Fixes #267.

Account for HOLD_INSTRUMENT in pattern checking

d7c481b

Include N163 period table in asm export

71f4f62

Clamp pitch and hi-pitch envelope period results

6f2c743

Gumball2415 force-pushed the app-emu-module-nsf_driver-dev branch from 39cb8f4 to 6f2c743 Compare March 22, 2024 17:57

Gumball2415 added 7 commits March 28, 2024 12:54

Align first sample in assembly export

ae6f162

Fix and refactor phase reset code

e6b4d19

Remove hardcoded bank reference in song header

4a4582f

Thanks, Zeta!

Enable pitch sliding in linear pitch mode

6ee2084

Implement bankswitched assembly config exports

7738f83

Add bank 0 for nonbankswitching config

4b88f22

Refactor NSFe metadata generation

b8425af

Gumball2415 mentioned this pull request Jun 2, 2024

FDS modulation is not exporting to NSF at all #275

Open

Gumball2415 added 3 commits June 21, 2024 18:05

Fix NES ROM export data alignment

fa05bd9

Fixes #278.

Fix DPCM segment start address in nonbankswitching

8a3ee83

Refactor Pitch/HiPitch bend logic

d92a3a1

Gumball2415 force-pushed the app-emu-module-nsf_driver-dev branch from 9e937ab to d92a3a1 Compare July 19, 2024 14:16

Gumball2415 added 3 commits July 20, 2024 13:17

Apply N163 slide shift if linear pitch is disabled

4cc1a5e

Addresses #276.

Implement linear pitch period limit

bdf33eb

- Correct linear pitch calculation sequence

Refactor period limit subroutine

4ce047d

Fixes #276.

Fix N163 portamento shift in linear period

718183d

Fixes #276.

Gumball2415 force-pushed the app-emu-module-nsf_driver-dev branch from 7eca46b to 718183d Compare July 22, 2024 10:36

Gumball2415 mentioned this pull request Jul 29, 2024

[Feature Request] Triangle linear counter retrigger command #291

Open

Refactor multifile export

72f32a6

Thanks, Leafuw and nyanpasu64!

Gumball2415 mentioned this pull request Sep 22, 2024

Fix filename handling with two filetype extensions #298

Open

Gumball2415 marked this pull request as ready for review September 22, 2024 10:16

Gumball2415 changed the title ~~NSF Driver Fixes~~ NSF Driver and Export Fixes Sep 22, 2024

Gumball2415 marked this pull request as draft October 5, 2024 15:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NSF Driver and Export Fixes #262

NSF Driver and Export Fixes #262

Gumball2415 commented Feb 17, 2024 •

edited

Loading

Gumball2415 commented Jun 13, 2024

Gumball2415 commented Jun 20, 2024

Gumball2415 commented Jul 20, 2024

NSF Driver and Export Fixes #262

Are you sure you want to change the base?

NSF Driver and Export Fixes #262

Conversation

Gumball2415 commented Feb 17, 2024 • edited Loading

Changes in this PR:

Gumball2415 commented Jun 13, 2024

Gumball2415 commented Jun 20, 2024

Gumball2415 commented Jul 20, 2024

Gumball2415 commented Feb 17, 2024 •

edited

Loading