Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run WPT test suite against Taffy #639

Open
nicoburns opened this issue Apr 8, 2024 · 0 comments
Open

Run WPT test suite against Taffy #639

nicoburns opened this issue Apr 8, 2024 · 0 comments
Labels
testing Additional tests or improvements to the testing infrastructure

Comments

@nicoburns
Copy link
Collaborator

nicoburns commented Apr 8, 2024

What problem does this solve or what need does it fill?

We need to be able to verify that Taffy's implementations of layout algorithms (Flexbox, CSS Grid, etc) are correct. Our current gentest system is excellent and allows us to compare to Chrome (and potentially other browsers). However, it only allows us to test features which our text fixtures cover, and while our test suite is reasonably extensive it pales in comparison to the WPT test suite, which is not only larger but is maintained by "tier 1 browser" (Chrome, Firefox, etc) developers and is what they use as the basis for ensuring interoperability

What solution would you like?

Create a WPT runner for Taffy that can run the (a subset of) the WPT tests against Taffy.

https://github.com/jkelleyrtp/stylo-dioxus could likely form a basis for a runner. It has rendering capabilities so it could be used to do "visual similarity" for "ref tests". And while it doesn't currently have scripting capabilities, those could potentially be bolted for running WPT tests.

A good initial target would be to run most of:

What alternative(s) have you considered?

  • Translating WPT tests into Taffy's existing gentest format
  • Not running WPT tests against Taffy

Additional context

@nicoburns nicoburns added the testing Additional tests or improvements to the testing infrastructure label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Additional tests or improvements to the testing infrastructure
Projects
None yet
Development

No branches or pull requests

1 participant