You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What problem does this solve or what need does it fill?
Images nodes have an "intrinsic aspect ratio". And this behaves slightly differently to a node with the aspect_ratio style set, so it would be useful to be able to create gentests for it.
What solution would you like?
In Taffy's terms, a intrinsic aspect ratio corresponds to measure function which will determine the other dimension based on an aspect ratio it is asked to measure itself with one dimension set. So I would like to propose that we allow for setting image nodes in gentests, and translate that into such a measure function.
We should have 2-3 standard images to use:
One which is square (1:1 aspect ratio)
One which is landscape (wider than it is tall)
One which is portrait (taller than it wide)
Additional context
The following can be used as an initial test cases:
What problem does this solve or what need does it fill?
Images nodes have an "intrinsic aspect ratio". And this behaves slightly differently to a node with the
aspect_ratio
style set, so it would be useful to be able to create gentests for it.What solution would you like?
In Taffy's terms, a intrinsic aspect ratio corresponds to measure function which will determine the other dimension based on an aspect ratio it is asked to measure itself with one dimension set. So I would like to propose that we allow for setting image nodes in gentests, and translate that into such a measure function.
We should have 2-3 standard images to use:
Additional context
The following can be used as an initial test cases:
The text was updated successfully, but these errors were encountered: