Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate SHAs for assets #28

Open
ealmloff opened this issue Apr 23, 2024 · 0 comments
Open

Generate SHAs for assets #28

ealmloff opened this issue Apr 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ealmloff
Copy link
Member

Specific Demand

Manganis should support generating SHAs for assets to support Subresource Integrity and prevent XSS attacks

Implement Suggestion

  • Initially, we should expose an option to generate a SHA for an asset in the manifest so that CLIs can retrieve the SHA
  • In the future we might be able to expose this as an option in the macro. We don't want to optimize assets in the macro because it runs in debug mode and the SHA should be generated from the optimized asset. We could cache a SHA or modify the SHA in the linked binary

Related to DioxusLabs/dioxus#1484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant