Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe switch back to template without subtemplates? #42

Open
Andrew15-5 opened this issue Jun 8, 2024 · 0 comments
Open

Maybe switch back to template without subtemplates? #42

Andrew15-5 opened this issue Jun 8, 2024 · 0 comments

Comments

@Andrew15-5
Copy link
Contributor

@ealmloff once said:

I don't think we should be using sub templates in the dioxus-template repo because we want to support multiple platforms at once in the future
But it is fine for now

When I opened #26 and created #27 there were no subtemplates and dx didn't support it until recently (DioxusLabs/dioxus#1872). But the default subtemplate (with --yes) can't be selected yet (cargo-generate/cargo-generate#1181). I don't know about #26, but #27 is now useless, and it looks like I can remove it. Another (small) problem is that LiveView's template name should be changed (small breaking change for those that already use dx new --subtemplate or cargo-generate).

One (and only?) noticeable disadvantage of not having subtemlates is that this significantly increases the number of conditions in files (and to fix #26 the way conditions are inserted in #27 isn't very nice, but manageable).

Related: #9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant