Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byte code dump tasks #165

Open
4 of 5 tasks
TheMostDiligent opened this issue Feb 20, 2022 · 0 comments
Open
4 of 5 tasks

Byte code dump tasks #165

TheMostDiligent opened this issue Feb 20, 2022 · 0 comments
Assignees

Comments

@TheMostDiligent
Copy link
Contributor

TheMostDiligent commented Feb 20, 2022

  • Move BytecodeDumper to anonymous namespace
  • If dump directory does not exist, none of the other directories will be created and dump will fail. The packager must create it.
  • Rework BytecodeDumper::WorkingDirectory to use std::stack. This will make it more robust. It is totally OK to traverse the entire stack every time in ComputePathFor. Compared to file operations this is will be done in no time
  • Add tests for byte code dump: create temporary directory in the current working directory (assets), dump files for each backend there and verify that files exist. Delete the directory afterwards.
    • If Metal is supported, validate that .metal and .metallib files are also created
  • Verify that everything works when either path or shader name contains white spaces, add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants