Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Notification system to extract the code for connecting to the message broker into a new class library #399

Open
Maxvanhattum opened this issue Mar 15, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@Maxvanhattum
Copy link
Contributor

Describe the bug
At the moment the Notificationsystem is a console application, which listens to the message broker and sends an email based on payloads. In this console application there is also code present for connecting/subscribing/listening to the message broker.
This code can AND is already reused in different places (jobscheduler and recommendationsystem), these applications now import all the code from the Notificationsystem console application, however they only use the parts to connect to the message broker.

Expected behavior
Applications that want to utilize the message broker service should only need to import the bare minimum code necessary for this to happen. Therefor this code should be separated into its own class library. The notification system (email based) should get a new dependency on this class library.
Other application should change their dependency to the new class library.

@Maxvanhattum Maxvanhattum added the bug Something isn't working label Mar 15, 2021
@Maxvanhattum Maxvanhattum self-assigned this Mar 15, 2021
@niraymak
Copy link
Member

niraymak commented Apr 8, 2021

Waiting for recommendation system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants