Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document socket subscription vs reconnect interactions #72

Open
zoe-codez opened this issue Sep 23, 2024 · 0 comments
Open

Document socket subscription vs reconnect interactions #72

zoe-codez opened this issue Sep 23, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@zoe-codez
Copy link
Member

🪤 Context

Unclear on if a hass.socket.subscribe should be done, and the implications of putting it in different spots:

  • root
  • lifecycle event
  • onConnect

Ideally these should all do the same thing, but not currently obvious if:

  • doing onConnect would lead to a memory leak
  • not doing onConnect would result in loss of subscriptions on reconnect

🩻 Additional details

  • add tests
  • tsdoc
  • official docs
@zoe-codez zoe-codez added the documentation Improvements or additions to documentation label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant