805 move p99 detectors into dodal #807
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Relm-Arrowny
requested review from
DiamondJoseph,
DominicOram and
callumforrester
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #807 +/- ##
==========================================
+ Coverage 95.12% 95.21% +0.08%
==========================================
Files 120 124 +4
Lines 4901 4993 +92
==========================================
+ Hits 4662 4754 +92
Misses 239 239 ☔ View full report in Codecov by Sentry. |
DominicOram
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Some comments in code. Additionally, I would recommend more tests that are smaller and more descriptive. For example:
test_get_deadtime_returns_expected<- just test deadtimetest_given_trigger_number_of_0_then_number_of_images_set_to_maxtest_given_no_live_time_then_esposure_time_not_set
The advantage of this is it very clearly lays out what is expected of the device and if one of them fail in the future it should be obvious to someone what went wrong. In general I would expect a device like this to have maybe a dozen small tests like this.
src/dodal/devices/areadetector/andor2_epics/andor2_controller.py
Outdated
Show resolved
Hide resolved
src/dodal/devices/areadetector/andor2_epics/andor2_controller.py
Outdated
Show resolved
Hide resolved
src/dodal/devices/areadetector/andor2_epics/andor2_controller.py
Outdated
Show resolved
Hide resolved
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #805
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}