Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support psr/container v2.x #23

Open
mecha opened this issue Sep 20, 2023 · 5 comments
Open

Support psr/container v2.x #23

mecha opened this issue Sep 20, 2023 · 5 comments

Comments

@mecha
Copy link
Member

mecha commented Sep 20, 2023

This package cannot currently be installed alongside psr/container v2.x. It explicitly depends on ^1.0.

Since v2 only adds the bool return type hint to ContainerInterface::has(), and given that this package doesn't have any classes that implement this interface, adding support should just be a matter of updating the version constraint in composer.json to also include ^2.0.

@mecha
Copy link
Member Author

mecha commented Sep 20, 2023

I started drafting a PR but I got stuck after finding out that the container-interop/service-provider package also depends on ^1.0 explicitly.

There is an open issue that discusses whether service-provider should depend on psr/container at all, and an open PR that removes the dependency. But until a solution gets merged into service-provider, this issue will likely remain blocked.

@XedinUnknown
Copy link
Member

Oh! That's unfortunate. Yes, I understrand the problem. I'll try to do something about it soon. Sorry for the inconvenience!

@XedinUnknown
Copy link
Member

Also. I'd like to re-visit the subject of removing dependency on service-provider altogether. Simply port the interface here. A bump to minor version of this package, and we move away. Since that standard appears unmaintained and nobody seems to be interested in it, I believe it's long overdue.

@mecha
Copy link
Member Author

mecha commented Oct 8, 2023

Cool. I'll go ahead and get started on a PR.

@mecha
Copy link
Member Author

mecha commented Dec 15, 2023

container-interop/service-provider now supports psr/container ^2.0 with the release of v0.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants