Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Ribasim XMI Wrapper into imod coupler #359

Open
deltamarnix opened this issue Jan 17, 2025 · 1 comment
Open

Move Ribasim XMI Wrapper into imod coupler #359

deltamarnix opened this issue Jan 17, 2025 · 1 comment
Assignees

Comments

@deltamarnix
Copy link
Contributor

Ribasim XMI Wrapper is now a separate package in the Ribasim repository. This is not required, as it's so small and won't grow in the future. I propose that we move the class into the imod coupler repo next to the other kernel wrappers.

Then in the Ribasim repo, we can make a PR that removes CI/CD and the ribasim_api folder.
It might be that we also need to remove a conda-forge recipe.

The alternative for users of this class is that they simply copy-paste it when they want to work with it separately without the imod coupler. That is always an option of course.

@visr Am I missing anything that could be removed?

@visr
Copy link
Member

visr commented Jan 17, 2025

Yes that is most of it. There are some mentions in the docs, and pixi.toml. It might be nice to change the docs with a link to the code in case they want to copy-paste.

And we should see how to properly deprecate the package on PyPI and conda-forge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants