Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable interpolation types #1932

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SouthEndMusic
Copy link
Collaborator

Fixes #1919.

Inspired by ongoing discussions with @Huite and @visr on smoothness (see also #1918, #1920) I started looking into making the type of interpolation configurable in the several places in the core where interpolation is used. For this PR I am focussing on $Q(h)$ relationships.

We require of the $Q(h)$ interpolation that the flow is $0$ below and at the lowest supplied level. That's trivial to achieve for linear interpolation, but not for non-linear (generally piecewise polynomial of degree >1) interpolation types. This requires a special approach for each method.

The question is which methods to support (and even whether this should be configurable for $Q(h)$ relationships at all). I now experiment with PCHIP Interpolation because of its smoothness and non-overshooting properties.

Another point of attention is extrapolation. For linear interpolation extrapolation makes sense, but for higher order interpolation methods extrapolation gets out of hand quick. We could make our own wrapper of interpolation types from DataInterpolation, but I also made an issue there to pick it up internally:

SciML/DataInterpolations.jl#355

@SouthEndMusic SouthEndMusic marked this pull request as draft November 13, 2024 13:38
@SouthEndMusic SouthEndMusic changed the title Configurable interpolation setup Configurable interpolation types Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smoothing the Q(h) relation
1 participant