Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validity Information for BatchFillerBBox2D #23

Open
twongjirad opened this issue Apr 23, 2018 · 4 comments
Open

Validity Information for BatchFillerBBox2D #23

twongjirad opened this issue Apr 23, 2018 · 4 comments
Assignees

Comments

@twongjirad
Copy link
Contributor

Return/create a (B,NMAXBB,1,1) matrix which designates valid boxes. However, how to create a BatchFiller routine that returns two template objects?

@twongjirad twongjirad self-assigned this Apr 23, 2018
@drinkingkazu
Copy link
Contributor

ATM BatchFiller classes (those inherit from BatchFillerTemplate) can only have 1 sd::vector as "batch data" to fill and return. Hence one has to write a separate algorithm to fill more than one data.

But it makes sense one wants to derive more than one information from single algorithm. I'll think on the plane about how to change this.

@twongjirad
Copy link
Contributor Author

Notes to self:

Hmm, have to create something like a BatchFillerTemplate that instead creates N BatchData holders for multiple items.

Either have to specify both template types (possible?), or restricted to all data being same type like float. then exposed to bugs due to float -> int conversions ...

... oh github page just updated, showing you are thinking about this already.

@drinkingkazu
Copy link
Contributor

One way to do this is to decouple BatchFiller algorithm being "filler" and "owner" of batch data at the same time. The "ownership" can be out-sourced to a dedicated data manager. I think BatchDataStorage or BatchDataStorageFactory are natural choices. I have to eliminate ownership from BatchFillerTemplate (which comes from BatchHolder or something). Yes, this will be a huge "let's remove this and that template" campaign :)

@twongjirad
Copy link
Contributor Author

for more thoughts on the problem of bounding box definitions in general, additional discussion here: #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants