Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces in ProcessType List #20

Open
coreyjadams opened this issue Jan 24, 2018 · 0 comments
Open

Spaces in ProcessType List #20

coreyjadams opened this issue Jan 24, 2018 · 0 comments

Comments

@coreyjadams
Copy link
Member

When writing a configuration file in larcv, spaces aren't allow in the configuration list. If you do accidentally have spaces, you get output that looks like this:

[NORMAL]  <ProcessDriver::configure> Instantiating Process ID=0 Type: ProdEventMeta2D w/ Name: ProdEventMeta2D
[NORMAL]  <ProcessDriver::configure> Instantiating Process ID=1 Type:  "Cluster2DThreshold w/ Name:  "Cluster2DThreshold
 [ERROR]  <ProcessFactory::create::L71> Found no registered class  "Cluster2DThreshold

To be clear, the difference in the configuration file is between this correct version:
ProcessType: ["ProdEventMeta2D","Cluster2DThreshold"] ProcessName: ["ProdEventMeta2D","Cluster2DThreshold"]

and this incorrect version:
ProcessType: ["ProdEventMeta2D", "Cluster2DThreshold"] ProcessName: ["ProdEventMeta2D", "Cluster2DThreshold"]

I don't want to cause a lot of work, but I spent a long time looking to find out today why my new class, Cluster2DThreshold, wasn't getting registered, and only figured out the problem when I noticed the " in the ERROR message.

We should do one of the following:

  • Implement better parsing to not complain about spaces
  • Implement better error messages to tell the user to fix their configuration file and stop search their C++ code forever.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant