Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite failures on armel, armhf, ppc64el and s390x #401

Open
tillea opened this issue Dec 4, 2022 · 1 comment
Open

Test suite failures on armel, armhf, ppc64el and s390x #401

tillea opened this issue Dec 4, 2022 · 1 comment
Milestone

Comments

@tillea
Copy link

tillea commented Dec 4, 2022

Hi,
the Debian R packaging team has packages estimatr for Debian. On some architectures it fails its test with:

══ Failed tests ════════════════════════════════════════════════════════════════
 ── Failure ('test-lm-robust-fes.R:589'): FEs handle collinear covariates ───────
 tidy(lmo)[grepl("cyl", lmo$term), ] not equivalent to tidy(lmfo)[grepl("cyl", lmfo$term), ].
 Component “estimate”: 'is.NA' value mismatch: 0 in current 1 in target
 Component “std.error”: 'is.NA' value mismatch: 0 in current 1 in target
 Component “statistic”: 'is.NA' value mismatch: 0 in current 1 in target
 Component “p.value”: 'is.NA' value mismatch: 0 in current 1 in target
 Component “conf.low”: 'is.NA' value mismatch: 0 in current 1 in target
 Component “conf.high”: 'is.NA' value mismatch: 0 in current 1 in target
 Component “df”: 'is.NA' value mismatch: 0 in current 1 in target
 ── Failure ('test-lm-robust-fes.R:589'): FEs handle collinear covariates ───────
 tidy(lmo)[grepl("cyl", lmo$term), ] not equivalent to tidy(lmfo)[grepl("cyl", lmfo$term), ].
 Component “estimate”: 'is.NA' value mismatch: 0 in current 1 in target
 Component “std.error”: 'is.NA' value mismatch: 0 in current 1 in target
 Component “statistic”: 'is.NA' value mismatch: 0 in current 1 in target
 Component “p.value”: 'is.NA' value mismatch: 0 in current 1 in target
 Component “conf.low”: 'is.NA' value mismatch: 0 in current 1 in target
 Component “conf.high”: 'is.NA' value mismatch: 0 in current 1 in target
 Component “df”: 'is.NA' value mismatch: 0 in current 1 in target
 ── Failure ('test-lm-robust-fes.R:589'): FEs handle collinear covariates ───────
 tidy(lmo)[grepl("cyl", lmo$term), ] not equivalent to tidy(lmfo)[grepl("cyl", lmfo$term), ].
 Component “estimate”: 'is.NA' value mismatch: 0 in current 1 in target
 Component “std.error”: 'is.NA' value mismatch: 0 in current 1 in target
 Component “statistic”: 'is.NA' value mismatch: 0 in current 1 in target
 Component “p.value”: 'is.NA' value mismatch: 0 in current 1 in target
 Component “conf.low”: 'is.NA' value mismatch: 0 in current 1 in target
 Component “conf.high”: 'is.NA' value mismatch: 0 in current 1 in target
 Component “df”: 'is.NA' value mismatch: 0 in current 1 in target
 ── Failure ('test-lm-robust-fes.R:622'): Handle perfect fits appropriately ─────
 tidy(rfo)[rfo$term == "X", ] not equivalent to tidy(ro)[ro$term == "X", ].
 Component “std.error”: 'is.NA' value mismatch: 1 in current 0 in target
 Component “statistic”: 'is.NA' value mismatch: 1 in current 0 in target
 Component “p.value”: 'is.NA' value mismatch: 1 in current 0 in target
 Component “conf.low”: 'is.NA' value mismatch: 1 in current 0 in target
 Component “conf.high”: 'is.NA' value mismatch: 1 in current 0 in target

[ FAIL 4 | WARN 0 | SKIP 11 | PASS 930 ]
Error: Test failures

Feel free to check a full example log for armel

Kind regards, Andreas.

@nfultz
Copy link
Contributor

nfultz commented Dec 5, 2022

@lukesonnet @graemeblair - these are testing for precision errors that occur differently on various processor architectures - we should probably just skip the tests if not on an x86.

@graemeblair graemeblair added this to the summer 2023 milestone May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants