Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain this comment better #7

Open
DavidBuchanan314 opened this issue Aug 29, 2024 · 0 comments
Open

Explain this comment better #7

DavidBuchanan314 opened this issue Aug 29, 2024 · 0 comments

Comments

@DavidBuchanan314
Copy link
Owner

DavidBuchanan314 commented Aug 29, 2024

assert(offset == len(data)) # should never fail!

On superficial re-review I thought this should be an if/raise, rather than an assert, but the condition should be impossible even on invalid inputs, due to the nature of the preceding loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant