diff --git a/tests/adapter/dbt_adapter/test_selector.py b/tests/adapter/dbt_adapter/test_selector.py index 07166c9f..17f8eb06 100644 --- a/tests/adapter/dbt_adapter/test_selector.py +++ b/tests/adapter/dbt_adapter/test_selector.py @@ -17,7 +17,7 @@ def test_select(dbt_test_helper): """ dbt_test_helper.create_model("customers_1", csv_data_base, csv_data_curr) - dbt_test_helper.create_model("customers_2", csv_data_base, csv_data_base, ["customers_1"]) + dbt_test_helper.create_model("customers_2", csv_data_base, csv_data_base, depends_on=["customers_1"]) adapter: DbtAdapter = dbt_test_helper.context.adapter # Test methods @@ -60,7 +60,7 @@ def test_select(dbt_test_helper): # Test resource type: snapshot dbt_test_helper.create_snapshot("snapshot_1", csv_data_base, csv_data_curr) - dbt_test_helper.create_model("use_snapshot", csv_data_base, csv_data_base, ["snapshot_1"]) + dbt_test_helper.create_model("use_snapshot", csv_data_base, csv_data_base, depends_on=["snapshot_1"]) node_ids = adapter.select_nodes('resource_type:snapshot') assert len(node_ids) == 1 diff --git a/tests/tasks/test_row_count.py b/tests/tasks/test_row_count.py index de119f5b..296bcf64 100644 --- a/tests/tasks/test_row_count.py +++ b/tests/tasks/test_row_count.py @@ -48,8 +48,9 @@ def test_row_count_with_selector(dbt_test_helper): 2,Bob,25 """ - dbt_test_helper.create_model("model_1", csv_data_1, csv_data_2, []) - dbt_test_helper.create_model("model_2", csv_data_1, csv_data_1, ['model_1'], package_name='other_package') + dbt_test_helper.create_model("model_1", csv_data_1, csv_data_2, depends_on=[]) + dbt_test_helper.create_model("model_2", csv_data_1, csv_data_1, depends_on=['model_1'], + package_name='other_package') task = RowCountDiffTask(dict(select='model_1')) run_result = task.execute() assert len(run_result) == 1 diff --git a/tests/util/test_breaking.py b/tests/util/test_breaking.py index 75dd8da4..db2108c3 100644 --- a/tests/util/test_breaking.py +++ b/tests/util/test_breaking.py @@ -1,8 +1,6 @@ import textwrap import unittest -import pytest - from recce.util.breaking import is_breaking_change @@ -108,20 +106,20 @@ def test_breaking_change_remove_column(self): """ assert is_breaking_change(original_sql, modified_sql) - @pytest.mark.skip("The case when cannot be detected by sqlglot") - def test_non_breaking_change_add_column_by_case_when(self): - original_sql = """ - select - a - from MyTable - """ - modified_sql = """ - select - a, - case when a > 100 then 1 else 0 end as b - from MyTable - """ - assert not is_breaking_change(original_sql, modified_sql) + # @pytest.mark.skip("The case when cannot be detected by sqlglot") + # def test_non_breaking_change_add_column_by_case_when(self): + # original_sql = """ + # select + # a + # from MyTable + # """ + # modified_sql = """ + # select + # a, + # case when a > 100 then 1 else 0 end as b + # from MyTable + # """ + # assert not is_breaking_change(original_sql, modified_sql) def test_breaking_change_add_filter(self): original_sql = """