Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tmp refs files are not deleted when no longer required #101

Closed
doulikecookiedough opened this issue May 30, 2024 · 1 comment
Closed

Tmp refs files are not deleted when no longer required #101

doulikecookiedough opened this issue May 30, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@doulikecookiedough
Copy link
Contributor

doulikecookiedough commented May 30, 2024

During the process to create refs files via tag_object, unnecessary cid* refs files are not being removed and building up in the /tmp directory.

Investigate the cause and resolve.

@doulikecookiedough doulikecookiedough added the bug Something isn't working label May 30, 2024
@doulikecookiedough
Copy link
Contributor Author

doulikecookiedough commented May 30, 2024

This has been resolved via BugFix-101: cid refs file does not get cleaned up

Note:

  • The atexit module should have handled clean up of cid refs files that were not moved/renamed, however it does not appear to have executed. I was unable to identify the exact cause, but creating files ahead of time is inefficient (not a good design choice). So tag_object has been revised to only create files when it is required, and this change appears to have resolved this issue.
  • While it's not clear why atexit functions did not execute after the python interpreter exited, I don't believe this to be a major issue. I am moving forward with this fix with the caveat that there is some unexpected behaviour with atexit that may need to be further investigated when time-permitting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant