New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert threshold is hard coded in the message of recommended monitors #507

Open

lym953 opened this issue Jul 29, 2024 · 0 comments

Assignees

Contributor

lym953 commented Jul 29, 2024 •

edited

Loading

Expected Behavior

The error message should either

mention the correct threshold, or
not mention the threshold

Actual Behavior

The error message mentions a wrong hard-coded threshold 10%.

Screenshot of Datadog Monitor UI:

Steps to Reproduce the Problem

Add this to serverless.yml of a Serverless Framework project

    monitors:
      - high_error_rate:
          options:
            thresholds:
              warning: 0.05
              critical: 0.5

(Neither threshold is 10%.)
2. deploy the project

Specifications

Serverless Framework version: 4.1.16
Datadog Serverless Plugin version: v5.67.0
Lambda function runtime (Python 3.7, Node 10, etc.): Python 3.12

The text was updated successfully, but these errors were encountered:

hghotra assigned sumedham

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment