Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing monitors doesn't work #486

Open
Bielik20 opened this issue Apr 23, 2024 · 1 comment
Open

Removing monitors doesn't work #486

Bielik20 opened this issue Apr 23, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Bielik20
Copy link

Bielik20 commented Apr 23, 2024

Expected Behavior

When running sls remove monitors are not deleted but left hanging.
Running deploy with monitors removed also doesn't work either even though documentation states otherwise:
image

Actual Behavior

Removing monitors or service doesn't remove monitors of that service.

Steps to Reproduce the Problem

  1. Deploy sls application with simple monitor
  2. Deploy sls application without monitor
  3. ❌ Monitor is still there
  4. Remove that sls application
  5. ❌ Monitor is still there

Specifications

  • Serverless Framework version: 3.38.0
  • Datadog Serverless Plugin version: 5.62.0
  • Lambda function runtime (Python 3.7, Node 10, etc.): Node 20
@astuyve
Copy link
Contributor

astuyve commented Apr 24, 2024

Hi @Bielik20, thanks for reaching out!

Right now we don't remove monitors on SLS remove, we don't even subscribe to any of those lifecycle events. At this time I don't expect to support that use case, but you're welcome to submit a PR if you're interested.

I'm not sure why removing an individual monitor didn't work for you. I'll try to reproduce that and take a look.

Thanks!

@duncanista duncanista added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants