Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New maintenance metrics for Consul integration #2187

Closed
diogokiss opened this issue Mar 16, 2018 · 3 comments
Closed

New maintenance metrics for Consul integration #2187

diogokiss opened this issue Mar 16, 2018 · 3 comments

Comments

@diogokiss
Copy link

Documentation Page

https://docs.datadoghq.com/integrations/consul

Issue Description

If DataDog/integrations-core#1267 gets approved and merged, it will add two new metrics called consul.catalog.services_maintenance and consul.catalog.nodes_maintenance to Consul integration. It might be interesting to add it to the official documentation.

@l0k0ms
Copy link
Contributor

l0k0ms commented Mar 16, 2018

Hello @diogokiss,

Many thanks for the update 🙇
In order to display those new metrics on the documentation you just need to edit the metadata.csv file for the integration on integrations-core: https://github.com/DataDog/integrations-core/blob/master/consul/metadata.csv in your PR.

On each build we pull this file to generate the metrics table here: https://docs.datadoghq.com/integrations/consul/#metrics (even if it seems that it's broken right now.. :/)

I'm going to pass a fix to display the metric table on consul doc, could you add the new metric to the metadata.csv file?

Best regards,
Pierre

@diogokiss
Copy link
Author

@l0k0ms, thanks for the instructions. I've updated the metadata.csv file in my PR (https://github.com/diogokiss/integrations-core/blob/ff6171d1865ac93a31084d94dae728e754b58606/consul/metadata.csv).

@l0k0ms
Copy link
Contributor

l0k0ms commented Mar 22, 2018

Hello,

The fix is merged for the metrics table, it will soon be displayed on the doc.
I'm going to close this issue for now, but if you spot other bugs or just have feedbacks regarding our documentation feel free to open a new one :)

Best regards,
Pierre

@l0k0ms l0k0ms closed this as completed Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants