From 5aeec4224a4826804f99f6eb647e62e1bdc0fe2b Mon Sep 17 00:00:00 2001 From: Dan Jing Date: Mon, 26 Aug 2024 20:22:53 +0800 Subject: [PATCH] [Enhancement] add metrics for analysis error (#50250) Signed-off-by: jingdan Signed-off-by: Dan Jing --- .../src/main/java/com/starrocks/metric/MetricRepo.java | 10 ++++++++++ .../main/java/com/starrocks/qe/ConnectProcessor.java | 6 ++++++ 2 files changed, 16 insertions(+) diff --git a/fe/fe-core/src/main/java/com/starrocks/metric/MetricRepo.java b/fe/fe-core/src/main/java/com/starrocks/metric/MetricRepo.java index 672f714b22200..14f301ed328b8 100644 --- a/fe/fe-core/src/main/java/com/starrocks/metric/MetricRepo.java +++ b/fe/fe-core/src/main/java/com/starrocks/metric/MetricRepo.java @@ -114,6 +114,9 @@ public final class MetricRepo { public static LongCounterMetric COUNTER_QUERY_QUEUE_TOTAL; public static LongCounterMetric COUNTER_QUERY_QUEUE_TIMEOUT; + public static LongCounterMetric COUNTER_QUERY_ANALYSIS_ERR; + public static LongCounterMetric COUNTER_QUERY_INTERNAL_ERR; + public static LongCounterMetric COUNTER_UNFINISHED_BACKUP_JOB; public static LongCounterMetric COUNTER_UNFINISHED_RESTORE_JOB; @@ -412,6 +415,13 @@ public Long getValue() { COUNTER_SHORTCIRCUIT_RPC = new LongCounterMetric("shortcircuit_rpc", MetricUnit.REQUESTS, "total shortcircuit rpc"); STARROCKS_METRIC_REGISTER.addMetric(COUNTER_SHORTCIRCUIT_RPC); + COUNTER_QUERY_ANALYSIS_ERR = new LongCounterMetric("query_analysis_err", MetricUnit.REQUESTS, + "total analysis error query"); + STARROCKS_METRIC_REGISTER.addMetric(COUNTER_QUERY_ANALYSIS_ERR); + COUNTER_QUERY_INTERNAL_ERR = new LongCounterMetric("query_internal_err", MetricUnit.REQUESTS, + "total internal error query"); + STARROCKS_METRIC_REGISTER.addMetric(COUNTER_QUERY_INTERNAL_ERR); + COUNTER_TXN_REJECT = new LongCounterMetric("txn_reject", MetricUnit.REQUESTS, "counter of rejected transactions"); STARROCKS_METRIC_REGISTER.addMetric(COUNTER_TXN_REJECT); diff --git a/fe/fe-core/src/main/java/com/starrocks/qe/ConnectProcessor.java b/fe/fe-core/src/main/java/com/starrocks/qe/ConnectProcessor.java index 21a3d62a6f7d6..34e3f085ffb17 100644 --- a/fe/fe-core/src/main/java/com/starrocks/qe/ConnectProcessor.java +++ b/fe/fe-core/src/main/java/com/starrocks/qe/ConnectProcessor.java @@ -204,6 +204,12 @@ public void auditAfterExec(String origStmt, StatementBase parsedStmt, PQueryStat MetricRepo.COUNTER_QUERY_ERR.increase(1L); ResourceGroupMetricMgr.increaseQueryErr(ctx, 1L); ctx.getAuditEventBuilder().setDigest(computeStatementDigest(parsedStmt)); + //represent analysis err + if (ctx.getState().getErrType() == QueryState.ErrType.ANALYSIS_ERR) { + MetricRepo.COUNTER_QUERY_ANALYSIS_ERR.increase(1L); + } else { + MetricRepo.COUNTER_QUERY_INTERNAL_ERR.increase(1L); + } } else { // ok query MetricRepo.COUNTER_QUERY_SUCCESS.increase(1L);