Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to destroy a videoprocessor #10

Open
balupton opened this issue Jan 25, 2014 · 3 comments
Open

How to destroy a videoprocessor #10

balupton opened this issue Jan 25, 2014 · 3 comments

Comments

@balupton
Copy link
Contributor

I'd like to be able to switch a videprocessor from a grayscale filter to a blue filter (I've already coded up the blue filter).

However I'm unsure how I destroy the videoproc instance to make way for the new videoproc instance with the new filter.

@DamonOehlman
Copy link
Owner

Good question - I'll need to implement something to allow a video proc to be cleanup properly.

With regards to changing filters, would you prefer to be able to leave the videoproc instance around and clear existing filters and add a new one instead of going through reinitialization again?

@balupton
Copy link
Contributor Author

With regards to changing filters, would you prefer to be able to leave the videoproc instance around and clear existing filters and add a new one instead of going through reinitialization again?

That would be ideal.

Good question - I'll need to implement something to allow a video proc to be cleanup properly.

That would be needed eventually...

@DamonOehlman
Copy link
Owner

Yeah, I'll leave this issue open until the cleanup stuff is taken care of.

I have exposed the filters array from the processor returned from the videoproc call. Direct manipulation of the processor.filters should change how filters are applied, e.g.:

processor.filters = [ require('bluefilter'); ];

NOTE: At this stage you can't modify processor.filter but I might add an attribute that does simply replace the contents of the filters array so you get this functionality too....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants