Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflections are added for each dynamic light #1358

Open
VReaperV opened this issue Oct 15, 2024 · 0 comments
Open

Reflections are added for each dynamic light #1358

VReaperV opened this issue Oct 15, 2024 · 0 comments

Comments

@VReaperV
Copy link
Contributor

computeDynamicLight() calls computeDeluxeLight(), which then adds the reflection colour if reflections are available. A simple fix would be to have an extra input or something to distinguish between the main light (lightmap) and the dynamic lights (or having 2 functions). However, if screen-space reflections are also added we'd need to put the reflection data into some sort of g-buffer (although doing SSR in the lightMapping shader might work too...), so this would no longer be an issue if both are enabled. Either way, this can be fixed as this issue isn't noticeable, at least visually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant