Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix blackbox #207

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix: Fix blackbox #207

wants to merge 11 commits into from

Conversation

huyenngn
Copy link
Member

@huyenngn huyenngn commented Jan 30, 2025 •
edited
Loading

Closes #186
Closes #192

  • There's now separate mode="BLACKBOX" and include_children_context=True params.
  • Add support for portless diagrams in custom collector
  • Use custom collector for portless context diagram, dataflow view diagram, interface context diagram, physical port context diagram, cable tree diagram
  • Separate builders and collectors submodule

@huyenngn huyenngn force-pushed the refactor-diagrams-custom branch from 57e0c2f to e3e929a Compare January 30, 2025 18:02
@huyenngn huyenngn force-pushed the refactor-diagrams-custom branch 2 times, most recently from a97e2be to b9bfa46 Compare February 1, 2025 11:51
@huyenngn huyenngn force-pushed the refactor-diagrams-custom branch from b9bfa46 to 91aa4ab Compare February 1, 2025 11:55
@huyenngn huyenngn force-pushed the refactor-diagrams-custom branch from e3cf0db to 2755b44 Compare February 2, 2025 16:30
@huyenngn huyenngn changed the title fix: WIP fix: Fix blackbox Feb 3, 2025
@huyenngn huyenngn force-pushed the refactor-diagrams-custom branch from aa4a351 to 60fca56 Compare February 3, 2025 14:39
@huyenngn huyenngn marked this pull request as ready for review February 3, 2025 14:44
@huyenngn huyenngn mentioned this pull request Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewuerger ewuerger Awaiting requested review from ewuerger ewuerger is a code owner

@vik378 vik378 Awaiting requested review from vik378 vik378 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@huyenngn