Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve organization of “chart gallery” #50

Open
2 tasks done
maggiejaenicke opened this issue Jan 29, 2024 · 6 comments
Open
2 tasks done

Improve organization of “chart gallery” #50

maggiejaenicke opened this issue Jan 29, 2024 · 6 comments
Assignees

Comments

@maggiejaenicke
Copy link
Contributor

maggiejaenicke commented Jan 29, 2024

There is a carousel for the 2023 30-day chart challenge, but other charts are organized sort of randomly. As this section grows, we’ll want to move them all to carousels so only a couple appear at once, but all can be browsed.

  • Organize U.S. River Conditions

    • Released quarterly
    • Ideally the most recent one or two would appear and the rest could be found by navigating a carousel
    • PR adding the most recent river conditions
  • Flow Tiles

    • Put in a carousel

Notes:
-Relates to / replaces #39
-There's a csv that controls everything on the landing page

Assignee: Maggie Jaenicke
(putting this here since I don't have repo access)

maggiejaenicke pushed a commit to maggiejaenicke/vizlab-home that referenced this issue Feb 11, 2024
…art and initiates new files for RiverConditions_Carousel
maggiejaenicke pushed a commit to maggiejaenicke/vizlab-home that referenced this issue Feb 11, 2024
maggiejaenicke pushed a commit to maggiejaenicke/vizlab-home that referenced this issue Feb 12, 2024
maggiejaenicke pushed a commit to maggiejaenicke/vizlab-home that referenced this issue Feb 16, 2024
…s, cleans up riverConditionsCharts object array, adjusts carousel to use river conditions charts for slider images
maggiejaenicke pushed a commit to maggiejaenicke/vizlab-home that referenced this issue Feb 16, 2024
maggiejaenicke pushed a commit to maggiejaenicke/vizlab-home that referenced this issue Mar 7, 2024
maggiejaenicke pushed a commit to maggiejaenicke/vizlab-home that referenced this issue Mar 7, 2024
…utlines to both flow and river conditions charts
maggiejaenicke pushed a commit to maggiejaenicke/vizlab-home that referenced this issue Mar 7, 2024
…in the site, removes those little boxes on Recent, Vis, and About in the header
maggiejaenicke pushed a commit to maggiejaenicke/vizlab-home that referenced this issue Mar 7, 2024
maggiejaenicke pushed a commit to maggiejaenicke/vizlab-home that referenced this issue Mar 7, 2024
maggiejaenicke pushed a commit to maggiejaenicke/vizlab-home that referenced this issue Mar 10, 2024
…ds in more videos to the js file, updates gray border styling for river conditions
maggiejaenicke pushed a commit to maggiejaenicke/vizlab-home that referenced this issue Mar 11, 2024
…r both flow and river conditions, adds link to river conditions code
maggiejaenicke pushed a commit to maggiejaenicke/vizlab-home that referenced this issue Mar 13, 2024
@aaarcher-usgs aaarcher-usgs reopened this Mar 18, 2024
@aaarcher-usgs
Copy link
Collaborator

aaarcher-usgs commented Mar 18, 2024

Reopening this to document some issues with the River Conditions chart gallery.

(NOTE: Turns out you have to disconnect VPN for the screenshots to show)

  • The gallery loads on Safari properly (first screenshot), but then disappears after hovering over the carousel (second screenshot)
  • Add the dates as text on the cards for river conditions so we can see when they're from at a glance on load before playing videos

MicrosoftTeams-image

MicrosoftTeams-image (1)

@maggiejaenicke
Copy link
Contributor Author

  • All of the drupal pages open when a video is clicked on--FIX so just one

@maggiejaenicke
Copy link
Contributor Author

maggiejaenicke commented Mar 20, 2024

@aaarcher-usgs

  • The gallery loads on Safari properly (first screenshot), but then disappears after hovering over the carousel (second screenshot)

Oh no! I'll do my best to look into this, but I am not allowed Safari on my machine, so it's difficult to test.

maggiejaenicke pushed a commit to maggiejaenicke/vizlab-home that referenced this issue Mar 25, 2024
…lick function, adjusts index order of river conditions and flow tiles
@cnell-usgs
Copy link
Member

I tried using a click event to control the playback instead of mouseover and mouseout to control the safari behavior here main...cnell-usgs:vizlab-home:click-video . It worked but then realized there's no way to get through to the full size video with this approach 😦

@maggiejaenicke
Copy link
Contributor Author

maggiejaenicke commented Mar 26, 2024

@cnell-usgs if you do it that way, have you tried adding "controls" into the video element, like in the code below? I have the mouseover and mouseout there just to add and remove the controls with the mouse just because I thought it looks better, but you can just have the controls on there straight up.

<video class="video" width="100%" :poster="getThumbnailUrl(chart.folder, chart.image_thumbnail)" controls> 
<source :src="getVideoUrl(chart.folder, chart.video_basename, chart.video_type)" type="video/mp4">
Your browser does not support the video tag.
</video>

Is there a way to detect which browser is being used? If so, we could leave the default controls on for Safari but have it dynamic for Chromium browsers?

@maggiejaenicke
Copy link
Contributor Author

@cnell-usgs Can you also test this code on Safari?

<video class="video" width="100%" :poster="getThumbnailUrl(chart.folder, chart.image_thumbnail)" onmouseover="this.setAttribute('controls','controls')" onmouseout="this.removeAttribute('controls')">
<source :src="getVideoUrl(chart.folder, chart.video_basename, chart.video_type)" type="video/mp4">
Your browser does not support the video tag.
</video>

maggiejaenicke pushed a commit to maggiejaenicke/vizlab-home that referenced this issue Mar 27, 2024
maggiejaenicke pushed a commit to maggiejaenicke/vizlab-home that referenced this issue Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants