Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for SDK Style csproj #3

Open
SkyeHoefling opened this issue Aug 17, 2020 · 1 comment
Open

Add Support for SDK Style csproj #3

SkyeHoefling opened this issue Aug 17, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@SkyeHoefling
Copy link
Contributor

The csproj uses the legacy style csproj and we should update it to use the new SDK Style csproj. This introduces some difficulties with the build tasks if I remember correctly. Here is an example of what I am thinking as a starting point

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>net472</TargetFramework>

    <!-- This allows VS Code Debugging -->
    <DebugType>Portable</DebugType>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="DotNetNuke.Abstractions" Version="9.4.2" />
    <PackageReference Include="DotNetNuke.DependencyInjection" Version="9.4.2" />
    <PackageReference Include="DotNetNuke.WebApi" Version="9.4.2" />
  </ItemGroup>

  <ItemGroup>
    <Reference Include="System.Web" />
  </ItemGroup>

</Project>
@david-poindexter david-poindexter added the enhancement New feature or request label Aug 17, 2020
@david-poindexter
Copy link
Contributor

@ahoefling I thought about this, but as you said, this may have some negative ramifications regarding the MSBuild hooks. We should investigate nonetheless. Thanks for posting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants