Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache duration isn't applied to the cache object #89

Open
arampendley opened this issue Dec 2, 2023 · 4 comments
Open

Cache duration isn't applied to the cache object #89

arampendley opened this issue Dec 2, 2023 · 4 comments

Comments

@arampendley
Copy link

arampendley commented Dec 2, 2023

Describe the bug

Cache duration isn't applied to the cache object

To Reproduce

Steps to reproduce the behavior:

  1. Go to Module Settings
  2. Enter a cache duration of 10 minutes
  3. Close editor
  4. View page

Expected behavior

The cache object should be cleared and reloaded after 10 minutes

Add me as a contributor and I will fix this.

@valadas
Copy link
Member

valadas commented Dec 4, 2023

@arampendley you can send a PR and I'll be happy to review/merge/release.
If you plan on doing multiple PRs let me know and I can wait for a few before a release.
Thanks.

@arampendley
Copy link
Author

arampendley commented Dec 4, 2023 via email

@valadas
Copy link
Member

valadas commented Dec 4, 2023

You can fork the repository to create a branch in your fork to submit a PR.

@arampendley
Copy link
Author

arampendley commented Dec 4, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants