Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Telerik UI components by standard DNN version #85

Open
EPTamminga opened this issue Jun 5, 2018 · 32 comments
Open

Replace Telerik UI components by standard DNN version #85

EPTamminga opened this issue Jun 5, 2018 · 32 comments

Comments

@EPTamminga
Copy link
Member

EPTamminga commented Jun 5, 2018

Remove all Telerik controls and replace by standard jQuery controls, so that the Telerik UI DLL is not referenced and not needed any more

@stale
Copy link

stale bot commented Feb 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue without activity for a long time label Feb 4, 2020
@stale
Copy link

stale bot commented Feb 25, 2020

This issue has been closed automatically due to inactivity (as mentioned 21 days ago).
Feel free to re-open the issue if you believe it is still relevant.

@stale stale bot closed this as completed Feb 25, 2020
@EPTamminga
Copy link
Member Author

Still relevant

@EPTamminga EPTamminga reopened this Feb 25, 2020
@stale stale bot removed the stale Issue without activity for a long time label Feb 25, 2020
@stale
Copy link

stale bot commented Aug 23, 2020

We have detected this issue has not had any activity during the last 180 days.
That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue.
We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 21 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future.
Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all.
Thank you for your continued involvement and contributions!

@stale stale bot added the stale Issue without activity for a long time label Aug 23, 2020
@stale
Copy link

stale bot commented Sep 13, 2020

This issue has been closed automatically due to inactivity (as mentioned 21 days ago).
Feel free to re-open the issue if you believe it is still relevant.

@stale stale bot closed this as completed Sep 13, 2020
@valadas
Copy link
Member

valadas commented Sep 13, 2020

Reopening this, we actually had a discussion in making the new Dnn one public instead of internal, we may be able to consume that one soon.

@valadas valadas reopened this Sep 13, 2020
@stale stale bot removed the stale Issue without activity for a long time label Sep 13, 2020
@MaiklT
Copy link

MaiklT commented Oct 25, 2020

This should be done asap, esp. because the new DNN 9.8.0 made a big step toward getting rid of Telerik components, and every day, those are getting more vulnerable.

@EPTamminga
Copy link
Member Author

I know and ist has been an issue for some time now. Problem is that it is not a simple replace. We have used some Telerik controls in the module, where is no simple open source equivalent.
We have a CoreModules team meeting next Thursday to discuss the options for several modules.

@X3Technology
Copy link

X3Technology commented Oct 25, 2020 via email

@EPTamminga
Copy link
Member Author

@mathisjay The date/time picker is not the biggest problem. The modules uses more Telerik controls, eg RadComboBox and uses functionality where I did not find a simple .js equivalent (yet)

@zyhfish
Copy link

zyhfish commented Oct 26, 2020

maybe you can use DnnComboBox which is built based on Selectize component.(https://selectize.github.io/selectize.js/)

@EPTamminga EPTamminga changed the title Replace Telerik date/time picker by standard DNN version Replace Telerik UI components by standard DNN version Nov 11, 2020
@JoeAucoin
Copy link

Reopening this, we actually had a discussion in making the new Dnn one public instead of internal, we may be able to consume that one soon.

Is this going to happen? I've got a number of sites using Events that I'd like to upgrade to DNN 9.9 and remove Telerik . . .

@EPTamminga
Copy link
Member Author

It should happen, but if you can provide a code submission (Pull Request) to solve some , it would help tremendously.

@valadas
Copy link
Member

valadas commented Mar 14, 2021

Just a heads up on that discussion, it was not properly marked as internal so it is officially public just in a namespace that is called internal and it is also not marked as deprecated, so we can use it for now, we did not want to move it to cause an unnecessary breaking change and we also don't want to recommend using it to third parties. However it should not go out any time soon, certainly not before DNN 11 or maybe more depending where we head with webforms in the distant future.

@brentil
Copy link

brentil commented Aug 26, 2021

Any progress on this process? There's now an official Critical vulnerability listed on the DNN security center for removing Telerik.

https://www.dnnsoftware.com/community/security/security-center

@EPTamminga
Copy link
Member Author

There is no progress atm. I welcome any code changes that facilitate this..

@MaiklT
Copy link

MaiklT commented Oct 19, 2021

Is there an OpenContent template for a replacement (not necessarily with all the functions of the Event module, I just need the calendar and - if possible - a way to register (no payments, but just send an email if someone is interested). Thanks.

@Timo-Breumelhof
Copy link

@MaiklT
I'm sure it's possible with a calendar JS plugin and also with a subscription form as there are inline forms in OC.
But I don't know of an existing template TBH

@stale
Copy link

stale bot commented Apr 18, 2022

We have detected this issue has not had any activity during the last 180 days.
That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue.
We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 21 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future.
Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all.
Thank you for your continued involvement and contributions!

@stale stale bot added the stale Issue without activity for a long time label Apr 18, 2022
@MaiklT
Copy link

MaiklT commented Apr 19, 2022

Still an issue

@stale stale bot removed the stale Issue without activity for a long time label Apr 19, 2022
@carizzio
Copy link

I just ran into this issue today on a new setup. I have DNN Platform v9.11.0 setup and functioning normally. Since this is a new installation with nothing in it I followed the instructions to remove Telerik. No issues with the removal and all the basic stuff appears to be working normally.

Being that the individuals that will be creating content for this site will be creating a calendar of events I downloaded the latest version of the Events Module from GitHub (Events Module v7.0.7).

I installed it from "Settings > Extensions" and it installed fine. The install log showed no errors. I then attempted to add the module to a test page and rant into the following...

Error: Events is currently unavailable. DotNetNuke.Services.Exceptions.ModuleLoadException: Could not load file or assembly 'DotNetNuke.Web.Deprecated' or one of its dependencies.

The full stack trace is...
Error: Events is currently unavailable. DotNetNuke.Services.Exceptions.ModuleLoadException: Could not load file or assembly 'DotNetNuke.Web.Deprecated' or one of its dependencies. The system cannot find the file specified. ---> System.Web.HttpParseException: Could not load file or assembly 'DotNetNuke.Web.Deprecated' or one of its dependencies. The system cannot find the file specified. ---> System.Web.HttpParseException: Could not load file or assembly 'DotNetNuke.Web.Deprecated' or one of its dependencies. The system cannot find the file specified. ---> System.IO.FileNotFoundException: Could not load file or assembly 'DotNetNuke.Web.Deprecated' or one of its dependencies. The system cannot find the file specified. at System.Reflection.RuntimeAssembly._nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, RuntimeAssembly locationHint, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks) at System.Reflection.RuntimeAssembly.nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, RuntimeAssembly locationHint, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks) at System.Reflection.RuntimeAssembly.InternalLoadAssemblyName(AssemblyName assemblyRef, Evidence assemblySecurity, RuntimeAssembly reqAssembly, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks) at System.Reflection.RuntimeAssembly.InternalLoad(String assemblyString, Evidence assemblySecurity, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean forIntrospection) at System.Reflection.RuntimeAssembly.InternalLoad(String assemblyString, Evidence assemblySecurity, StackCrawlMark& stackMark, Boolean forIntrospection) at System.Reflection.Assembly.Load(String assemblyString) at System.Web.Configuration.CompilationSection.LoadAssembly(String assemblyName, Boolean throwOnFail) at System.Web.UI.TemplateParser.LoadAssembly(String assemblyName, Boolean throwOnFail) at System.Web.UI.TemplateParser.AddAssemblyDependency(String assemblyName, Boolean addDependentAssemblies) at System.Web.UI.MainTagNameToTypeMapper.ProcessTagNamespaceRegistrationCore(TagNamespaceRegisterEntry nsRegisterEntry) at System.Web.UI.MainTagNameToTypeMapper.ProcessTagNamespaceRegistration(TagNamespaceRegisterEntry nsRegisterEntry) at System.Web.UI.BaseTemplateParser.ProcessDirective(String directiveName, IDictionary directive) at System.Web.UI.TemplateControlParser.ProcessDirective(String directiveName, IDictionary directive) at System.Web.UI.TemplateParser.ParseStringInternal(String text, Encoding fileEncoding) --- End of inner exception stack trace --- at System.Web.UI.TemplateParser.ProcessException(Exception ex) at System.Web.UI.TemplateParser.ParseStringInternal(String text, Encoding fileEncoding) at System.Web.UI.TemplateParser.ParseString(String text, VirtualPath virtualPath, Encoding fileEncoding) --- End of inner exception stack trace --- at System.Web.UI.TemplateParser.ProcessException(Exception ex) at System.Web.UI.TemplateParser.ParseStringInternal(String text, Encoding fileEncoding) at System.Web.UI.TemplateParser.ParseString(String text, VirtualPath virtualPath, Encoding fileEncoding) at System.Web.UI.TemplateParser.ParseFile(String physicalPath, VirtualPath virtualPath) at System.Web.UI.TemplateParser.ParseInternal() at System.Web.UI.TemplateParser.Parse() at System.Web.Compilation.BaseTemplateBuildProvider.get_CodeCompilerType() at System.Web.Compilation.BuildProvider.GetCompilerTypeFromBuildProvider(BuildProvider buildProvider) at System.Web.Compilation.BuildProvidersCompiler.ProcessBuildProviders() at System.Web.Compilation.BuildProvidersCompiler.PerformBuild() at System.Web.Compilation.BuildManager.CompileWebFile(VirtualPath virtualPath) at System.Web.Compilation.BuildManager.GetVPathBuildResultInternal(VirtualPath virtualPath, Boolean noBuild, Boolean allowCrossApp, Boolean allowBuildInPrecompile, Boolean throwIfNotFound, Boolean ensureIsUpToDate) at System.Web.Compilation.BuildManager.GetVPathBuildResultWithNoAssert(HttpContext context, VirtualPath virtualPath, Boolean noBuild, Boolean allowCrossApp, Boolean allowBuildInPrecompile, Boolean throwIfNotFound, Boolean ensureIsUpToDate) at System.Web.UI.TemplateControl.LoadControl(VirtualPath virtualPath) at System.Web.UI.TemplateControl.LoadControl(String virtualPath) at DotNetNuke.Modules.Events.Events.LoadModuleControl() --- End of inner exception stack trace ---

@MaiklT
Copy link

MaiklT commented Oct 3, 2022

I followed the instructions to remove Telerik.

Error: Events is currently unavailable. DotNetNuke.Services.Exceptions.ModuleLoadException: Could not load file or assembly 'DotNetNuke.Web.Deprecated' or one of its dependencies.

Dnn.Events ist still dependent on the Telerik components, I am afraid. So removing them causes exactly the issue described.

It is strongly recommended to use another extension, it should be not too hard to create one using OpenContent or 2sxc.

@carizzio
Copy link

carizzio commented Oct 3, 2022

Thank you MaikIT! That was my suspicion, but I didn't see any comments about the Telerik components, so I was hopeful.

@jncraig
Copy link

jncraig commented Oct 3, 2022 via email

@carizzio
Copy link

carizzio commented Oct 3, 2022

Thanks jncraig. I certainly will check out the "Event Registration" module

@james7342
Copy link

Any developer(s) out there interested in contributing to fix this? Maybe as a user community we could sponsor someone to make this happen. This is becoming a critical change. Once a core DNN module is dying on the vine.

@WillStrohl
Copy link
Member

WillStrohl commented Jul 12, 2023

I'm sure that many developers are willing. However, the effort required will likely require that one or more developers are sponsored in some way. This often happens for our team via the various forms of DNN support we offer to clients. In your case, you may want to shop around the various contributors here, and then maybe take a look at those in the community with an agency, or plenty of DNN experience.

I only mention all of these options, because not everyone is paying attention to the comments in community module repos. :)

@innovation2solution
Copy link

innovation2solution commented Nov 23, 2023

Hi everyone, first of all, I just wanted to say how much I/we (the DNN community) appreciate all the work that goes into DNN and it's supported modules. You guys are awesome and thank you very much for continuing to support the community over the years....I still see some familiar faces and names around this space in the well over 10 years i've been using DNN now.

I just wanted to ask with the imminent release of DNN10 if there will be any updates to this module as my understanding is that Telerik will no longer be an option and therefore will this module be defunct as a result, is my understanding correct?

If so, are there any plans to provide an update/support in prep for DNN10 or to coincide or should we start looking and planning for alternatives?

My preference is to continue to always try and use community supported modules, like the FAQ module which has recently been updated to remove the Telerik components so we can continue to use it.

@valadas
Copy link
Member

valadas commented Nov 23, 2023

@innovation2solution As this is an open source project, someone just has to put the time to remove Telerik from it. On some modules it was a simple/medium task. I believe for this one it would be more involved as it is a complex module and it deals with dates/times and everyone know how easy it is to break logic on date/time so it would also involve a lot of testing.

All that to say, there is no plan on maintaining it or not, it all depends on someone volunteering to make the code happen on sponsoring someone to do so.

I myself don't use this module so would not be the best for testing anything on it. I could help someone who has a proper test bed to try and replace some of those controls.

@james7342
Copy link

I have a multiple testing environments that could be used for testing. Just don't have the programming skills. This is one of the modules we use extensively on our sites and been concerned with what's going to happen to it. I've been looking and unable to find anything with the similar features this module supports.

@Timo-Breumelhof
Copy link

Timo-Breumelhof commented Nov 24, 2023

@james7342 When you look for someone you can sponsor to make the change, you could also ask for one in the forums https://dnncommunity.org/forums

@Timo-Breumelhof
Copy link

@james7342 maybe we could also find others using he module that would like to sponsor..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests