-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Telerik UI components by standard DNN version #85
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been closed automatically due to inactivity (as mentioned 21 days ago). |
Still relevant |
We have detected this issue has not had any activity during the last 180 days. |
This issue has been closed automatically due to inactivity (as mentioned 21 days ago). |
Reopening this, we actually had a discussion in making the new Dnn one public instead of internal, we may be able to consume that one soon. |
This should be done asap, esp. because the new DNN 9.8.0 made a big step toward getting rid of Telerik components, and every day, those are getting more vulnerable. |
I know and ist has been an issue for some time now. Problem is that it is not a simple replace. We have used some Telerik controls in the module, where is no simple open source equivalent. |
Take a look at flatpickr. Will Strohl used it in the Blog module.
https://flatpickr.js.org/
From: Ernst Peter Tamminga <[email protected]>
Sent: Sunday, October 25, 2020 8:38 AM
To: DNNCommunity/DNN.Events <[email protected]>
Cc: Subscribed <[email protected]>
Subject: Re: [DNNCommunity/DNN.Events] Replace Telerik date/time picker by standard DNN version (#85)
I know and ist has been an issue for some time now. Problem is that it is not a simple replace. We have used some Telerik controls in the module, where is no simple open source equivalent.
We have a CoreModules team meeting next Thursday to discuss the options for several modules.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#85 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMDENK623PBZGXNYHND5GTSMQLZ3ANCNFSM4FDJLD7Q> . <https://github.com/notifications/beacon/AAMDENOVMVUPO3TYHK52KZ3SMQLZ3A5CNFSM4FDJLD72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFKXXGTQ.gif>
|
@mathisjay The date/time picker is not the biggest problem. The modules uses more Telerik controls, eg RadComboBox and uses functionality where I did not find a simple .js equivalent (yet) |
maybe you can use DnnComboBox which is built based on Selectize component.(https://selectize.github.io/selectize.js/) |
Is this going to happen? I've got a number of sites using Events that I'd like to upgrade to DNN 9.9 and remove Telerik . . . |
It should happen, but if you can provide a code submission (Pull Request) to solve some , it would help tremendously. |
Just a heads up on that discussion, it was not properly marked as internal so it is officially public just in a namespace that is called internal and it is also not marked as deprecated, so we can use it for now, we did not want to move it to cause an unnecessary breaking change and we also don't want to recommend using it to third parties. However it should not go out any time soon, certainly not before DNN 11 or maybe more depending where we head with webforms in the distant future. |
Any progress on this process? There's now an official Critical vulnerability listed on the DNN security center for removing Telerik. https://www.dnnsoftware.com/community/security/security-center |
There is no progress atm. I welcome any code changes that facilitate this.. |
Is there an OpenContent template for a replacement (not necessarily with all the functions of the Event module, I just need the calendar and - if possible - a way to register (no payments, but just send an email if someone is interested). Thanks. |
@MaiklT |
We have detected this issue has not had any activity during the last 180 days. |
Still an issue |
I just ran into this issue today on a new setup. I have DNN Platform v9.11.0 setup and functioning normally. Since this is a new installation with nothing in it I followed the instructions to remove Telerik. No issues with the removal and all the basic stuff appears to be working normally. Being that the individuals that will be creating content for this site will be creating a calendar of events I downloaded the latest version of the Events Module from GitHub (Events Module v7.0.7). I installed it from "Settings > Extensions" and it installed fine. The install log showed no errors. I then attempted to add the module to a test page and rant into the following... Error: Events is currently unavailable. DotNetNuke.Services.Exceptions.ModuleLoadException: Could not load file or assembly 'DotNetNuke.Web.Deprecated' or one of its dependencies. The full stack trace is... |
Dnn.Events ist still dependent on the Telerik components, I am afraid. So removing them causes exactly the issue described. It is strongly recommended to use another extension, it should be not too hard to create one using OpenContent or 2sxc. |
Thank you MaikIT! That was my suspicion, but I didn't see any comments about the Telerik components, so I was hopeful. |
I’ll beg to differ a tiny bit with Michael. Creating N events module is a
fairly large undertaking. The issue is managing the various events wit a
variety of recurrences,
My recommendation is the Event Registration module from NA Development,
sure, it costs money, but it is far less a price than doing it yourself.
I’m pretty sure it is free of Telerik, but check first.
…On Mon, Oct 3, 2022 at 8:45 AM carizzio ***@***.***> wrote:
Thank you MaikIT! That was my suspicion, but I didn't see any comments
about the Telerik components, so I was hopeful.
—
Reply to this email directly, view it on GitHub
<#85 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABEDMRP7PSRFZL5GMZW7E33WBLIPNANCNFSM4FDJLD7Q>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Thanks jncraig. I certainly will check out the "Event Registration" module |
Any developer(s) out there interested in contributing to fix this? Maybe as a user community we could sponsor someone to make this happen. This is becoming a critical change. Once a core DNN module is dying on the vine. |
I'm sure that many developers are willing. However, the effort required will likely require that one or more developers are sponsored in some way. This often happens for our team via the various forms of DNN support we offer to clients. In your case, you may want to shop around the various contributors here, and then maybe take a look at those in the community with an agency, or plenty of DNN experience. I only mention all of these options, because not everyone is paying attention to the comments in community module repos. :) |
Hi everyone, first of all, I just wanted to say how much I/we (the DNN community) appreciate all the work that goes into DNN and it's supported modules. You guys are awesome and thank you very much for continuing to support the community over the years....I still see some familiar faces and names around this space in the well over 10 years i've been using DNN now. I just wanted to ask with the imminent release of DNN10 if there will be any updates to this module as my understanding is that Telerik will no longer be an option and therefore will this module be defunct as a result, is my understanding correct? If so, are there any plans to provide an update/support in prep for DNN10 or to coincide or should we start looking and planning for alternatives? My preference is to continue to always try and use community supported modules, like the FAQ module which has recently been updated to remove the Telerik components so we can continue to use it. |
@innovation2solution As this is an open source project, someone just has to put the time to remove Telerik from it. On some modules it was a simple/medium task. I believe for this one it would be more involved as it is a complex module and it deals with dates/times and everyone know how easy it is to break logic on date/time so it would also involve a lot of testing. All that to say, there is no plan on maintaining it or not, it all depends on someone volunteering to make the code happen on sponsoring someone to do so. I myself don't use this module so would not be the best for testing anything on it. I could help someone who has a proper test bed to try and replace some of those controls. |
I have a multiple testing environments that could be used for testing. Just don't have the programming skills. This is one of the modules we use extensively on our sites and been concerned with what's going to happen to it. I've been looking and unable to find anything with the similar features this module supports. |
@james7342 When you look for someone you can sponsor to make the change, you could also ask for one in the forums https://dnncommunity.org/forums |
@james7342 maybe we could also find others using he module that would like to sponsor.. |
Remove all Telerik controls and replace by standard jQuery controls, so that the Telerik UI DLL is not referenced and not needed any more
The text was updated successfully, but these errors were encountered: