Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison with tensorflow1/2 implementation #56

Closed
a-z-e-r-i-l-a opened this issue Jun 10, 2020 · 4 comments
Closed

Comparison with tensorflow1/2 implementation #56

a-z-e-r-i-l-a opened this issue Jun 10, 2020 · 4 comments
Labels
question Further information is requested

Comments

@a-z-e-r-i-l-a
Copy link

I wanted to ask if you expect better performance using pytorch in stable-baselines3 than if it was going to be implemented with tensorflow2 ( or compared to the currently implemented tensorflow1). If so, from what aspects do you expect the advantages be in the end?

@Miffyli
Copy link
Collaborator

Miffyli commented Jun 10, 2020

Possibly some related discussion in #20

It is hard to say yet how far the optimizations can go, but we expect slightly lower performance (in terms of wall-clock time) than TF1 because PyTorch is eager. However this should not be significant after code is written to follow PyTorch's guidelines, and it will provide much cleaner code overall. We chose PyTorch over TF2 partially because of majority vote.

@Miffyli Miffyli added the question Further information is requested label Jun 10, 2020
@araffin
Copy link
Member

araffin commented Jun 10, 2020

Hello,
what type of performance are you talking about?
wall clock time? score in the environments?

@a-z-e-r-i-l-a
Copy link
Author

yea I meant about wall clock time or any other aspect which you may have thought about, specifically compared to TF2.

It seemed to me that there is a tendency towards PyTorch more than TF2 but I couldn't guess why. and was wondering if there is any advantage in using PyTorch compared to TF2.

@araffin
Copy link
Member

araffin commented Jun 11, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants