Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up documentation #36

Open
jiweiqi opened this issue Apr 23, 2021 · 17 comments
Open

Set up documentation #36

jiweiqi opened this issue Apr 23, 2021 · 17 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@jiweiqi
Copy link
Member

jiweiqi commented Apr 23, 2021

https://sparkbox.com/foundry/github_wiki_tutorial_for_technical_wiki_documentation

@jiweiqi
Copy link
Member Author

jiweiqi commented Apr 30, 2021

@jiweiqi jiweiqi changed the title Set up documentation in a separate repo Set up documentation Apr 30, 2021
@jiweiqi
Copy link
Member Author

jiweiqi commented Apr 30, 2021

@jiweiqi jiweiqi added the documentation Improvements or additions to documentation label Apr 30, 2021
@jiweiqi jiweiqi pinned this issue May 5, 2021
@jiweiqi
Copy link
Member Author

jiweiqi commented May 7, 2021

@RSuryaNarayan You can start from this example to get familiar with Arrhenius.jl

@RSuryaNarayan
Copy link
Contributor

Sure @jiweiqi ! Shall go through.

@RSuryaNarayan
Copy link
Contributor

@jiweiqi
Copy link
Member Author

jiweiqi commented May 9, 2021

@RSuryaNarayan I think it is a good practice to send a PR and get familiar with it.

@RSuryaNarayan
Copy link
Contributor

Sure @jiweiqi I shall send the PR right away

@jiweiqi
Copy link
Member Author

jiweiqi commented May 9, 2021

@RSuryaNarayan A very minor remind, you may forget to specify the language for the following code block

@inbounds function dudt!(du, u, p, t)
    T = u[end]
    Y = @view(u[1:ns])
    mean_MW = 1. / dot(Y, 1 ./ gas.MW)
    ρ_mass = P / R / T * mean_MW
    X = Y2X(gas, Y, mean_MW)
    C = Y2C(gas, Y, ρ_mass)
    cp_mole, cp_mass = get_cp(gas, T, X, mean_MW)
    h_mole = get_H(gas, T, Y, X)
    S0 = get_S(gas, T, P, X)
    wdot = wdot_func(gas.reaction, T, C, S0, h_mole)
    Ydot = wdot / ρ_mass .* gas.MW
    Tdot = -dot(h_mole, wdot) / ρ_mass / cp_mass
    du .= vcat(Ydot, Tdot)
end

Without specifying language,

@inbounds function dudt!(du, u, p, t)
    T = u[end]
    Y = @view(u[1:ns])
    mean_MW = 1. / dot(Y, 1 ./ gas.MW)
    ρ_mass = P / R / T * mean_MW
    X = Y2X(gas, Y, mean_MW)
    C = Y2C(gas, Y, ρ_mass)
    cp_mole, cp_mass = get_cp(gas, T, X, mean_MW)
    h_mole = get_H(gas, T, Y, X)
    S0 = get_S(gas, T, P, X)
    wdot = wdot_func(gas.reaction, T, C, S0, h_mole)
    Ydot = wdot / ρ_mass .* gas.MW
    Tdot = -dot(h_mole, wdot) / ρ_mass / cp_mass
    du .= vcat(Ydot, Tdot)
end

@jiweiqi
Copy link
Member Author

jiweiqi commented May 9, 2021

@RSuryaNarayan BTW, it seems that .svg can not be correctly displayed on the website. You may try .png next time.

@RSuryaNarayan
Copy link
Contributor

Ah sorry for these bugs @jiweiqi shall correct them next time

@RSuryaNarayan
Copy link
Contributor

@jiweiqi the PNG doesn't render in the preview of the markdown for some reason. I have committed it nonetheless. Pls check the new PR

@jiweiqi
Copy link
Member Author

jiweiqi commented May 9, 2021

I think the PNG file generated has something wrong. You can see an example here https://github.com/DENG-MIT/Arrhenius.jl/blob/main/docs/src/figures/schem.png.

@RSuryaNarayan
Copy link
Contributor

Aha no @jiweiqi that is not the problem. I meant the PNG file itself doesn't render as an image after I upload it.

@jiweiqi
Copy link
Member Author

jiweiqi commented May 9, 2021

Oh, it is alright. We can fix it later.
Can you show me the code you used to save the plot to a file in Julia.

@jiweiqi
Copy link
Member Author

jiweiqi commented May 9, 2021

I was using this one png(pltsum, "JP10_pyrolysis.png"). This should give a png file. It seems the file you uploaded is still in svg format.

@RSuryaNarayan
Copy link
Contributor

@jiweiqi I seem to have used the right format now. It still doesn't render ryt?

@jiweiqi
Copy link
Member Author

jiweiqi commented May 9, 2021

@RSuryaNarayan I just fixed it by changing the file path as ![](./figures/JP10.png).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants