-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature to add syl
when syllable
doesn't have one
#1265
Comments
I checked the files you provided. You are not seeing the bbox for the syllable text because the One thing I could do in Neon is to generate a bbox based on the syllable position, like the default bbox when you insert a syllable. How does that sound to you? And I will check the cause of these all-zero zones in |
Found it: DDMAL/Rodan#643 |
@JoyfulGen could you please provide the input files to |
That would be perfect, thank you! I'll put the files you asked for in the MEI encoding issue |
<facs>
syl
when syllable
doesn't have one
- Add <syl> element with text - Skip adding default syl for syllables for Neon refs: DDMAL/Neon#1265
- Notify users when syllables have no syl - Add `Add Syllable Text` button - Add `ADD_TEXT` modal window refs: #1265, rism-digital/verovio#3918
- Add <syl> element with text - Skip adding default syl for syllables for Neon refs: DDMAL/Neon#1265
- Add <syl> element with text - Skip adding default syl for syllables for Neon refs: DDMAL/Neon#1265
- Add <syl> element with text - Skip adding default syl for syllables for Neon refs: DDMAL/Neon#1265
- Notify users when syllables have no syl - Add `Add Syllable Text` button - Add `ADD_TEXT` modal window refs: #1265, rism-digital/verovio#3918
Hi, the changes should be up in production now :) |
Whoa cool! I think the notification is very clear and I like the new button. It works very well! I messed around with it a bunch and could not find anything wrong with it. It's a good solution, thank you! I'll close the issue. |
One of the MS73 folios I processed in November has a syllable that doesn't have a
<facs>
element, so it doesn't have a bounding box. It's the very first syllable: 141v-285.mei.zipI made an issue about that in the MEI_encoding repo, but there's still the question of how Neon should deal with a syllable like that if it happens. At the moment, if I ungroup the syllable that has no
<facs>
, this happens:<facs>
;<facs>
, but all of their bounding boxes have both anlry
and auly
of 0, so they're effectively invisible.@yinanazhou would it be possible for Neon to assign a syllable a
<facs>
if it doesn't have one? I suppose another solution would be to delete the offending syllable, but in the case of the file I've uploaded here the bad syllable is huge, so deleting it would remove almost all the neumes on the first staff.The text was updated successfully, but these errors were encountered: