Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to add syl when syllable doesn't have one #1265

Closed
JoyfulGen opened this issue Jan 14, 2025 · 6 comments
Closed

Feature to add syl when syllable doesn't have one #1265

JoyfulGen opened this issue Jan 14, 2025 · 6 comments
Labels
bug Something isn't working to-be-merged Fixed, but waiting for RISM to merge changes to develop.

Comments

@JoyfulGen
Copy link
Contributor

One of the MS73 folios I processed in November has a syllable that doesn't have a <facs> element, so it doesn't have a bounding box. It's the very first syllable: 141v-285.mei.zip

I made an issue about that in the MEI_encoding repo, but there's still the question of how Neon should deal with a syllable like that if it happens. At the moment, if I ungroup the syllable that has no <facs>, this happens:

  • The first resulting baby syllable also doesn't have a <facs>;
  • All of the other resulting baby syllables do have a <facs>, but all of their bounding boxes have both an lry and a uly of 0, so they're effectively invisible.

@yinanazhou would it be possible for Neon to assign a syllable a <facs> if it doesn't have one? I suppose another solution would be to delete the offending syllable, but in the case of the file I've uploaded here the bad syllable is huge, so deleting it would remove almost all the neumes on the first staff.

@JoyfulGen JoyfulGen added the bug Something isn't working label Jan 14, 2025
@yinanazhou
Copy link
Member

I checked the files you provided. You are not seeing the bbox for the syllable text because the <zone> is invalid, all the coordinates are 0s. And Neon check and remove these invalid zones and its corresponding elements. I remember invalid all-zero zones have happened before, but I can't find the issue :(

One thing I could do in Neon is to generate a bbox based on the syllable position, like the default bbox when you insert a syllable. How does that sound to you?

And I will check the cause of these all-zero zones in MEI encoding.

@yinanazhou
Copy link
Member

Found it: DDMAL/Rodan#643

@yinanazhou
Copy link
Member

@JoyfulGen could you please provide the input files to MEI encoding so that I can locate the issue in Rodan? Thanks!

@JoyfulGen
Copy link
Contributor Author

One thing I could do in Neon is to generate a bbox based on the syllable position, like the default bbox when you insert a syllable. How does that sound to you?

That would be perfect, thank you! I'll put the files you asked for in the MEI encoding issue

@yinanazhou yinanazhou changed the title What to do if a syllable has no <facs> Feature to add syl when syllable doesn't have one Jan 22, 2025
yinanazhou added a commit to DDMAL/verovio that referenced this issue Jan 24, 2025
- Add <syl> element with text
- Skip adding default syl for syllables for Neon

refs: DDMAL/Neon#1265
yinanazhou added a commit that referenced this issue Jan 24, 2025
- Notify users when syllables have no syl
- Add `Add Syllable Text` button
- Add `ADD_TEXT` modal window

refs: #1265, rism-digital/verovio#3918
@yinanazhou yinanazhou added the to-be-merged Fixed, but waiting for RISM to merge changes to develop. label Jan 24, 2025
yinanazhou added a commit to DDMAL/verovio that referenced this issue Jan 27, 2025
- Add <syl> element with text
- Skip adding default syl for syllables for Neon

refs: DDMAL/Neon#1265
yinanazhou added a commit to DDMAL/verovio that referenced this issue Jan 28, 2025
- Add <syl> element with text
- Skip adding default syl for syllables for Neon

refs: DDMAL/Neon#1265
yinanazhou added a commit to DDMAL/verovio that referenced this issue Jan 29, 2025
- Add <syl> element with text
- Skip adding default syl for syllables for Neon

refs: DDMAL/Neon#1265
yinanazhou added a commit that referenced this issue Jan 29, 2025
- Notify users when syllables have no syl
- Add `Add Syllable Text` button
- Add `ADD_TEXT` modal window

refs: #1265, rism-digital/verovio#3918
@yinanazhou
Copy link
Member

Hi, the changes should be up in production now :)

@JoyfulGen
Copy link
Contributor Author

Whoa cool! I think the notification is very clear and I like the new button. It works very well! I messed around with it a bunch and could not find anything wrong with it. It's a good solution, thank you! I'll close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working to-be-merged Fixed, but waiting for RISM to merge changes to develop.
Projects
None yet
Development

No branches or pull requests

2 participants