Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New layer improvements/bug fixes #178

Open
pettter opened this issue Dec 15, 2021 · 0 comments
Open

New layer improvements/bug fixes #178

pettter opened this issue Dec 15, 2021 · 0 comments

Comments

@pettter
Copy link
Contributor

pettter commented Dec 15, 2021

If a staff is empty of notes (in particular in its first measure) this gives an error, due to the computation of the pitch grid depending on finding the center line of the staff and a note with a known pitch to give the right offset. This should be fixed by

  • Removing empty staves
  • Calculating the right offset using the clefs rather than random notes. This isn't necessarily easy, because the IDs don't seem to match with the MEI for some reason, but I think the symbol IDs are consistent, so we can find the clef and it's height, and compare that to the height of the middle line of the staff, in theory.
@pettter pettter mentioned this issue Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant