From c50f3e016c383a0a1348b5a3bbaa4e169929bf8e Mon Sep 17 00:00:00 2001 From: Asbelos Date: Sun, 27 Oct 2024 13:53:34 +0000 Subject: [PATCH] No functional change Unused parameter removal & end of file tidying by the Arduino IDE --- CommandDistributor.cpp | 1 - DCCACK.cpp | 1 - DCCTimerAVR.cpp | 2 ++ DCCTimerESP.cpp | 1 - EXRAIL2Parser.cpp | 1 - EXRAILSensor.h | 2 +- I2CManager_NonBlocking.h | 2 +- I2CManager_Wire.h | 2 +- IODevice.cpp | 1 - IO_AnalogueInputs.h | 2 +- IO_DCCAccessory.cpp | 1 - IO_EncoderThrottle.cpp | 1 - IO_ExampleSerial.h | 2 +- IO_HALDisplay.h | 2 +- IO_MCP23008.h | 2 +- IO_MCP23017.h | 2 +- IO_NeoPixel.h | 3 ++- IO_PCA9685pwm.h | 2 +- IO_PCF8574.h | 2 +- IO_PCF8575.h | 2 +- IO_Servo.cpp | 1 - IO_Servo.h | 2 +- IO_TCA8418.h | 2 +- IO_TM1638.cpp | 2 -- IO_TouchKeypad.h | 2 +- IO_duinoNodes.h | 2 +- IO_trainbrains.h | 2 +- KeywordHasher.h | 2 +- LiquidCrystal_I2C.cpp | 2 +- StringBuffer.cpp | 2 -- StringBuffer.h | 2 +- TrackManager.cpp | 1 - Turnouts.cpp | 1 - 33 files changed, 23 insertions(+), 34 deletions(-) diff --git a/CommandDistributor.cpp b/CommandDistributor.cpp index be23577e..e889f62f 100644 --- a/CommandDistributor.cpp +++ b/CommandDistributor.cpp @@ -377,4 +377,3 @@ void CommandDistributor::setVirtualLCDSerial(Print * stream) { Print* CommandDistributor::virtualLCDSerial=&USB_SERIAL; byte CommandDistributor::virtualLCDClient=0xFF; byte CommandDistributor::rememberVLCDClient=0; - diff --git a/DCCACK.cpp b/DCCACK.cpp index 9d335295..64dafa32 100644 --- a/DCCACK.cpp +++ b/DCCACK.cpp @@ -483,4 +483,3 @@ void DCCACK::checkAck(byte sentResetsSincePacket) { } ackPulseStart=0; // We have detected a too-short or too-long pulse so ignore and wait for next leading edge } - diff --git a/DCCTimerAVR.cpp b/DCCTimerAVR.cpp index 656ba7e3..5f828d72 100644 --- a/DCCTimerAVR.cpp +++ b/DCCTimerAVR.cpp @@ -197,6 +197,8 @@ void DCCTimer::DCCEXanalogWriteFrequency(uint8_t pin, uint32_t f) { } void DCCTimer::DCCEXanalogWriteFrequencyInternal(uint8_t pin, uint32_t fbits) { #if defined(ARDUINO_AVR_UNO) + (void)fbits; + (void) pin; // Not worth doin something here as: // If we are on pin 9 or 10 we are on Timer1 and we can not touch Timer1 as that is our DCC source. // If we are on pin 5 or 6 we are on Timer 0 ad we can not touch Timer0 as that is millis() etc. diff --git a/DCCTimerESP.cpp b/DCCTimerESP.cpp index 39824a57..31dc2b10 100644 --- a/DCCTimerESP.cpp +++ b/DCCTimerESP.cpp @@ -324,4 +324,3 @@ void ADCee::begin() { } #endif //ESP32 - diff --git a/EXRAIL2Parser.cpp b/EXRAIL2Parser.cpp index a26d78a0..63bace0a 100644 --- a/EXRAIL2Parser.cpp +++ b/EXRAIL2Parser.cpp @@ -363,4 +363,3 @@ bool RMFT2::parseSlash(Print * stream, byte & paramCount, int16_t p[]) { return false; } } - diff --git a/EXRAILSensor.h b/EXRAILSensor.h index b5b00c65..c9929f61 100644 --- a/EXRAILSensor.h +++ b/EXRAILSensor.h @@ -47,4 +47,4 @@ class EXRAILSensor { bool onChange; byte latchDelay; }; -#endif \ No newline at end of file +#endif diff --git a/I2CManager_NonBlocking.h b/I2CManager_NonBlocking.h index 59bbcafc..83e1a2f0 100644 --- a/I2CManager_NonBlocking.h +++ b/I2CManager_NonBlocking.h @@ -384,4 +384,4 @@ void I2CManagerClass::handleInterrupt() { } } -#endif \ No newline at end of file +#endif diff --git a/I2CManager_Wire.h b/I2CManager_Wire.h index 1fd4d677..83249193 100644 --- a/I2CManager_Wire.h +++ b/I2CManager_Wire.h @@ -231,4 +231,4 @@ void I2CManagerClass::queueRequest(I2CRB *req) { ***************************************************************************/ void I2CManagerClass::loop() {} -#endif \ No newline at end of file +#endif diff --git a/IODevice.cpp b/IODevice.cpp index 5d3397e5..2a990bf2 100644 --- a/IODevice.cpp +++ b/IODevice.cpp @@ -627,4 +627,3 @@ bool ArduinoPins::fastReadDigital(uint8_t pin) { #endif return result; } - diff --git a/IO_AnalogueInputs.h b/IO_AnalogueInputs.h index a78503f3..e9d25a75 100644 --- a/IO_AnalogueInputs.h +++ b/IO_AnalogueInputs.h @@ -166,4 +166,4 @@ class ADS111x: public IODevice { uint8_t _nextState; }; -#endif // io_analogueinputs_h \ No newline at end of file +#endif // io_analogueinputs_h diff --git a/IO_DCCAccessory.cpp b/IO_DCCAccessory.cpp index 3e60e3b9..e138da53 100644 --- a/IO_DCCAccessory.cpp +++ b/IO_DCCAccessory.cpp @@ -65,4 +65,3 @@ void DCCAccessoryDecoder::_display() { DIAG(F("DCCAccessoryDecoder Configured on Vpins:%u-%u Addresses %d/%d-%d/%d)"), _firstVpin, _firstVpin+_nPins-1, ADDRESS(_packedAddress), SUBADDRESS(_packedAddress), ADDRESS(endAddress), SUBADDRESS(endAddress)); } - diff --git a/IO_EncoderThrottle.cpp b/IO_EncoderThrottle.cpp index 76a5f85c..e6019a83 100644 --- a/IO_EncoderThrottle.cpp +++ b/IO_EncoderThrottle.cpp @@ -141,4 +141,3 @@ const byte _DIR_MASK = 0x30; void EncoderThrottle::_display() { DIAG(F("DRIVE vpin %d loco %d notch %d"),_firstVpin,_locoid,_notch); } - diff --git a/IO_ExampleSerial.h b/IO_ExampleSerial.h index 5c70eb4f..8ecdb834 100644 --- a/IO_ExampleSerial.h +++ b/IO_ExampleSerial.h @@ -162,4 +162,4 @@ class IO_ExampleSerial : public IODevice { }; -#endif // IO_EXAMPLESERIAL_H \ No newline at end of file +#endif // IO_EXAMPLESERIAL_H diff --git a/IO_HALDisplay.h b/IO_HALDisplay.h index 24ffde7b..5bf16a11 100644 --- a/IO_HALDisplay.h +++ b/IO_HALDisplay.h @@ -262,4 +262,4 @@ class HALDisplay : public IODevice, public DisplayInterface { }; -#endif // IO_HALDisplay_H \ No newline at end of file +#endif // IO_HALDisplay_H diff --git a/IO_MCP23008.h b/IO_MCP23008.h index 9598a504..277d3eab 100644 --- a/IO_MCP23008.h +++ b/IO_MCP23008.h @@ -98,4 +98,4 @@ class MCP23008 : public GPIOBase { }; -#endif \ No newline at end of file +#endif diff --git a/IO_MCP23017.h b/IO_MCP23017.h index 7bdc2887..b53d3e36 100644 --- a/IO_MCP23017.h +++ b/IO_MCP23017.h @@ -108,4 +108,4 @@ class MCP23017 : public GPIOBase { }; -#endif \ No newline at end of file +#endif diff --git a/IO_NeoPixel.h b/IO_NeoPixel.h index 09966b5b..03d32542 100644 --- a/IO_NeoPixel.h +++ b/IO_NeoPixel.h @@ -206,6 +206,7 @@ class NeoPixel : public IODevice { // loop called by HAL supervisor void _loop(unsigned long currentMicros) override { + (void)currentMicros; if (!_showPendimg) return; byte showBuffer[]={SEESAW_NEOPIXEL_BASE,SEESAW_NEOPIXEL_SHOW}; I2CManager.write(_I2CAddress,showBuffer,sizeof(showBuffer)); @@ -291,7 +292,7 @@ class NeoPixel : public IODevice { } - void transmit(uint16_t pixel, bool show=true) { + void transmit(uint16_t pixel) { byte buffer[]={SEESAW_NEOPIXEL_BASE,SEESAW_NEOPIXEL_BUF,0x00,0x00,0x00,0x00,0x00}; uint16_t offset= pixel * _bytesPerPixel; buffer[2]=(byte)(offset>>8); diff --git a/IO_PCA9685pwm.h b/IO_PCA9685pwm.h index a12cb84d..98885b83 100644 --- a/IO_PCA9685pwm.h +++ b/IO_PCA9685pwm.h @@ -167,4 +167,4 @@ class PCA9685pwm : public IODevice { }; -#endif \ No newline at end of file +#endif diff --git a/IO_PCF8574.h b/IO_PCF8574.h index d71a32a2..17241eeb 100644 --- a/IO_PCF8574.h +++ b/IO_PCF8574.h @@ -101,4 +101,4 @@ class PCF8574 : public GPIOBase { uint8_t inputBuffer[1]; }; -#endif \ No newline at end of file +#endif diff --git a/IO_PCF8575.h b/IO_PCF8575.h index 0674617b..4d9caa18 100644 --- a/IO_PCF8575.h +++ b/IO_PCF8575.h @@ -106,4 +106,4 @@ class PCF8575 : public GPIOBase { uint8_t inputBuffer[2]; }; -#endif \ No newline at end of file +#endif diff --git a/IO_Servo.cpp b/IO_Servo.cpp index d59c1def..841fe686 100644 --- a/IO_Servo.cpp +++ b/IO_Servo.cpp @@ -30,4 +30,3 @@ // const uint8_t FLASH Servo::_bounceProfile[30] = {0,2,3,7,13,33,50,83,100,83,75,70,65,60,60,65,74,84,100,83,75,70,70,72,75,80,87,92,97,100}; - diff --git a/IO_Servo.h b/IO_Servo.h index 9e3211e3..4e50bf39 100644 --- a/IO_Servo.h +++ b/IO_Servo.h @@ -295,4 +295,4 @@ class Servo : IODevice { } }; -#endif \ No newline at end of file +#endif diff --git a/IO_TCA8418.h b/IO_TCA8418.h index 2ea1f767..f2ff99c6 100644 --- a/IO_TCA8418.h +++ b/IO_TCA8418.h @@ -368,4 +368,4 @@ class TCA8418 : public IODevice { }; }; -#endif \ No newline at end of file +#endif diff --git a/IO_TM1638.cpp b/IO_TM1638.cpp index 45614f6e..48d4602d 100644 --- a/IO_TM1638.cpp +++ b/IO_TM1638.cpp @@ -213,5 +213,3 @@ void TM1638::test(){ } } - - diff --git a/IO_TouchKeypad.h b/IO_TouchKeypad.h index 48e3b254..0fc7b08f 100644 --- a/IO_TouchKeypad.h +++ b/IO_TouchKeypad.h @@ -131,4 +131,4 @@ class TouchKeypad : public IODevice { }; -#endif // IO_TOUCHKEYPAD_H \ No newline at end of file +#endif // IO_TOUCHKEYPAD_H diff --git a/IO_duinoNodes.h b/IO_duinoNodes.h index c764db21..f9cc0fc9 100644 --- a/IO_duinoNodes.h +++ b/IO_duinoNodes.h @@ -170,4 +170,4 @@ class IO_DNOU8 { } }; -#endif \ No newline at end of file +#endif diff --git a/IO_trainbrains.h b/IO_trainbrains.h index 058fe025..b762fd1d 100644 --- a/IO_trainbrains.h +++ b/IO_trainbrains.h @@ -95,4 +95,4 @@ class Trainbrains02 : public GPIOBase { }; -#endif \ No newline at end of file +#endif diff --git a/KeywordHasher.h b/KeywordHasher.h index fe85eb4f..16ff9270 100644 --- a/KeywordHasher.h +++ b/KeywordHasher.h @@ -93,4 +93,4 @@ constexpr uint32_t operator""_s7(const char * keyword, size_t len) { return CompiletimeSeg7(keyword,0*len,4); } -#endif \ No newline at end of file +#endif diff --git a/LiquidCrystal_I2C.cpp b/LiquidCrystal_I2C.cpp index 1354024b..a517f614 100644 --- a/LiquidCrystal_I2C.cpp +++ b/LiquidCrystal_I2C.cpp @@ -221,4 +221,4 @@ void LiquidCrystal_I2C::expanderWrite(uint8_t value) { rb.wait(); outputBuffer[0] = value | _backlightval; I2CManager.write(_Addr, outputBuffer, 1, &rb); // Write command asynchronously -} \ No newline at end of file +} diff --git a/StringBuffer.cpp b/StringBuffer.cpp index dd4e4771..014bf876 100644 --- a/StringBuffer.cpp +++ b/StringBuffer.cpp @@ -41,5 +41,3 @@ size_t StringBuffer::write(uint8_t b) { _buffer[_pos_write]='\0'; return 1; } - - diff --git a/StringBuffer.h b/StringBuffer.h index ac429644..8bf3458d 100644 --- a/StringBuffer.h +++ b/StringBuffer.h @@ -35,4 +35,4 @@ class StringBuffer : public Print { char _buffer[buffer_max+2]; }; -#endif \ No newline at end of file +#endif diff --git a/TrackManager.cpp b/TrackManager.cpp index 6b37cefc..b4863bc4 100644 --- a/TrackManager.cpp +++ b/TrackManager.cpp @@ -697,4 +697,3 @@ TRACK_MODE TrackManager::getMode(byte t) { int16_t TrackManager::returnDCAddr(byte t) { return (trackDCAddr[t]); } - diff --git a/Turnouts.cpp b/Turnouts.cpp index ca5f8900..ffc5e93a 100644 --- a/Turnouts.cpp +++ b/Turnouts.cpp @@ -527,4 +527,3 @@ StringFormatter::send(stream, F("\n"), _turnoutData.id, !_turnoutData.closed); } -