Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/Incoming background color not visible with changed permissions #53

Open
ssvw opened this issue Nov 24, 2014 · 4 comments
Open

/Incoming background color not visible with changed permissions #53

ssvw opened this issue Nov 24, 2014 · 4 comments
Assignees

Comments

@ssvw
Copy link
Contributor

ssvw commented Nov 24, 2014

As I cannot change permissions very conveniently back and forth, I have assigned this to olsha for further testing.

I have got a feeling that if permissions are added, like for instance in

https://lux17.mpi.nl/ds/webannotator/api/annotations/b43a397e-aba8-406d-90c6-96c2ab4bf585:

this affects public users who visit the website in that the background color (light yellow) does not show up any more.

Annotations where permissions have not been changed are not affected, e.g.

https://lux17.mpi.nl/ds/webannotator/api/annotations/4241b8fe-df2e-4803-9e65-388dd90002dc

Can you help me affirm (or reject) this assumption - or trace what the difference is otherwise. I have run into this issue several times - and am still not sure about the cause. So, maybe it is due to permission change?

@ssvw
Copy link
Contributor Author

ssvw commented Nov 24, 2014

github erased the html snippets, so pls check for the permissions tags and their contents for the respective annotations.

Thanks.

@ssvw
Copy link
Contributor Author

ssvw commented Nov 24, 2014

<permissions xmlns="http://www.dasish.eu/ns/addit" public="read"/> 

@ssvw
Copy link
Contributor Author

ssvw commented Nov 24, 2014

<permissions public="read">
        <permission principalHref="/ds/webannotator/api/principals/0c01ef24-3bf4-4b8c-815f-ca406deb058d" level="write"/>
    </permissions> 

@olhsha
Copy link

olhsha commented Nov 24, 2014

It looks like I cannot reproduce the issue (still on the freshest local version of the backend). I have done the following.
-- Created two anntations as "olha-basic", making "olha2" as "write" and "all" respectively.
-- Made a new profile "olha2" with the xpi compiled from github sources.
-- Logged in in olha2 profile as "olha2". Both annotations of olha-basic where visible as incoming.
-- "olha2" tried to change the permissions where she is "write". Got 403 as expected.
-- "olha2" tried to change the permissions of the annotations where she is "all"(added a new one). worked, also checked via the backend.
-- "olha-basic" looked at the annotations, they were still available with their original colour.
-- "olha-basic" made the second annotation also "all" for olha2, so the permissions have been changed.
-- "olha2" reloaded the page, clicked on one of the annotations in the list. They both are still visible in light-yellow.
-- "olha2" deleted one annotation succesfully (diasppeared from lthe backend and a slight yellow), however "olha-basic" still is able to see the deleted annotation locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants