Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getRecentTime() should not be used when tracing is enabled #2390

Closed
lifflander opened this issue Jan 9, 2025 · 0 comments · Fixed by #2394
Closed

getRecentTime() should not be used when tracing is enabled #2390

lifflander opened this issue Jan 9, 2025 · 0 comments · Fixed by #2394
Assignees
@cwschilly
Labels
type: bug

Comments

@lifflander
Copy link
Collaborator

Describe the bug
In runnable.cc, using the "recent time" to avoid calling the timer which is expensive leads to highly inaccurate traces. We should get the current time when tracing is compile-time enabled and being used at runtime (i.e., the trace context is enabled for a runnable).
cwschilly added a commit that referenced this issue Jan 10, 2025
@cwschilly
#2390: use timing::getCurrentTime() when trace is enabled
b00db82
@cwschilly cwschilly mentioned this issue Jan 10, 2025
Merged
@cwschilly cwschilly linked a pull request Jan 10, 2025 that will close this issue
#2390: getRecentTime() should not be used when tracing is enabled #2394
Merged
cwschilly added a commit that referenced this issue Jan 10, 2025
@cwschilly
#2390: refactor to reduce duplication
83327c6
cwschilly added a commit that referenced this issue Jan 13, 2025
@cwschilly
#2390: fix condition formatting
0f159c0
cwschilly added a commit that referenced this issue Jan 14, 2025
@cwschilly
#2390: use timing::getCurrentTime() when trace is enabled
ed8151f
cwschilly added a commit that referenced this issue Jan 14, 2025
@cwschilly
#2390: refactor to reduce duplication
60acaae
cwschilly added a commit that referenced this issue Jan 14, 2025
@cwschilly
#2390: fix condition formatting
d74fd9e
lifflander added a commit that referenced this issue Jan 20, 2025
@lifflander
Merge pull request #2394 from DARMA-tasking/2390-getrecenttime-should…
e4e445f 
…-not-be-used-when-tracing-is-enabled

#2390: getRecentTime() should not be used when tracing is enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwschilly cwschilly

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2390: getRecentTime() should not be used when tracing is enabled DARMA-tasking/vt
2 participants
@lifflander @cwschilly