Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logic in LBDatafile_schema #2350

Closed
cwschilly opened this issue Sep 23, 2024 · 0 comments · Fixed by #2351
Closed

Improve logic in LBDatafile_schema #2350

cwschilly opened this issue Sep 23, 2024 · 0 comments · Fixed by #2351
Assignees

Comments

@cwschilly
Copy link
Contributor

To avoid key errors in the Schema, we should replace

    if field["migratable"] and 'seq_id' in field and 'collection_id' not in field:
        raise ValueError('If an entity is migratable, it must have a collection_id')

with

    if field.get("migratable") is True and 'seq_id' in field and 'collection_id' not in field:
        raise ValueError('If an entity is migratable, it must have a collection_id')

As suggested by @tlamonthezie in LBAF PR 538

@cwschilly cwschilly self-assigned this Sep 23, 2024
cwschilly added a commit that referenced this issue Sep 23, 2024
@cwschilly cwschilly linked a pull request Sep 23, 2024 that will close this issue
nlslatt added a commit that referenced this issue Sep 23, 2024
…atafile_schema

#2350: Improve logic in LBDatafile_schema
cwschilly added a commit that referenced this issue Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant