Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add member link in toast message after member creation #1681

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Add member link in toast message after member creation #1681

merged 3 commits into from
Oct 24, 2023

Conversation

peoray
Copy link
Contributor

@peoray peoray commented Oct 14, 2023 •
edited by ghost
Loading

Changes proposed ✍️

What

Fixes #1584

🤖 Generated by Copilot at da5675d

This pull request adds a new feature to the frontend that allows users to view the contact details of a newly created member entity. It updates the en.js locale file with a new translation key and modifies the actions.js file to display a button with a link to the contact page.
​

🤖 Generated by Copilot at da5675d

New View contact
Button for member entity
Spring of user joy

Why

How

🤖 Generated by Copilot at da5675d

  • Add a new translation key for 'View contact' message in English locale file (link)
  • Modify the logic for displaying a success message after creating a new entity in the frontend (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@peoray
Copy link
Contributor Author

peoray commented Oct 14, 2023

@joanagmaia are there plans to update the spanish and portuguese words to be the same with English. I added the 'View contact' to the en.js but not sure how to go about with the other versions of es and br

@joanagmaia
Copy link
Contributor

@joanagmaia are there plans to update the spanish and portuguese words to be the same with English. I added the 'View contact' to the en.js but not sure how to go about with the other versions of es and br

Hey @peoray, not really. Even though we still have those files, currently we are not updating them since supporting multiple languages is not in our roadmap for now

joanagmaia
joanagmaia requested changes Oct 16, 2023
View reviewed changes
frontend/src/i18n/en.js Outdated Show resolved Hide resolved
frontend/src/i18n/en.js Outdated Show resolved Hide resolved
frontend/src/shared/store/actions.js Outdated Show resolved Hide resolved
joanagmaia
joanagmaia approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@joanagmaia joanagmaia merged commit acf5c08 into CrowdDotDev:main Oct 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanagmaia joanagmaia joanagmaia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C-2295] Add member link in toast message after member creation
2 participants
@peoray @joanagmaia