Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE on chunk unload #44

Open
PhanaticD opened this issue Oct 27, 2017 · 0 comments
Open

NPE on chunk unload #44

PhanaticD opened this issue Oct 27, 2017 · 0 comments

Comments

@PhanaticD
Copy link

2017-10-26 12:41:18 [ALERT] java.lang.RuntimeException: java.lang.RuntimeException: java.lang.NullPointerException
    at cn.nukkit.level.Level.saveChunks(Level.java:1200)
    at cn.nukkit.level.Level.save(Level.java:1183)
    at cn.nukkit.level.Level.save(Level.java:1167)
    at cn.nukkit.Server.doAutoSave(Server.java:973)
    at cn.nukkit.Server.tick(Server.java:1030)
    at cn.nukkit.Server.tickProcessor(Server.java:800)
    at cn.nukkit.Server.start(Server.java:779)
    at cn.nukkit.Server.<init>(Server.java:470)
    at cn.nukkit.Nukkit.main(Nukkit.java:68)
Caused by: java.lang.RuntimeException: java.lang.NullPointerException
    at cn.nukkit.level.format.anvil.Anvil.saveChunk(Anvil.java:279)
    at cn.nukkit.level.Level.saveChunks(Level.java:1196)
    ... 8 more
Caused by: java.lang.NullPointerException
^M

nukkit version as of this commit 830091c

Creeperface01 added a commit that referenced this issue Nov 13, 2017
* Reduce memory usage, phase 2 (Zlib) (Nukkit#1790)

* Small improvement for Zlib

* Rearrange

* Test class for Zlib

* Fix Bug HostName Transfer 

 logged out due to Transferred to 43.xxx.xx.xx/43.xx.xx.xx:12345:12345

-.-

* Bug Report Feature

* Add the support to change Apply Effect in PotionApplyEvent (Nukkit#1811)

* Fixed furnaces crafting bug and more stoneware. Fixed Nukkit#1770

* Add the support to change Apply Effect in PotionApplyEvent.

* Fix for Issue Nukkit#1795, non-arrow projectiles should not cause damage.

* Fix for Issue Nukkit#1795: Non-arrow projectiles should not cause damage.

* Fixed mmethod access and annotation.

* Fix for issue Nukkit#1817 -- main thread stuck (rollback Zlib)

* MINECARTS available. Enjoy riding minecarts! (Nukkit#1763)

* Minecart can move!

* Minecart friendly clazz

* Removed unused SetEntityLink....

* Some missing pieces

* Add files via upload

* Small piece to move vehicle

Buggy but works

* Fix player position.

Thank you @Snake1999 for new Entity Data from 1.0 branch
(DATA_RIDER_SEAT_POSITION)

* Add minecart movement on move packet

* Some fix when colliding minecart

Still buggy but player wont bounced away
Track logic for buggy rails
new API on Entity

* Woops

* Fix entity data

Wrong entity data riding seat position :P.
New Rail Abstract
Mobs will dismount vehicle if vehicle is dead

* Time to go rouge

Fix MinecartTNT (exploded non stop)
Minecart can now have new display block!
New packet from @Creeperface01

* FIX

* Minecart collides better than before!

Huge minstake! Problem solved
Minecart moves -1 when not on rail not solved yet. todo
:+1:

* Minecart are now Stable!

Fixed minecart yaw
Fix glitch on minecart
Minecart will be on the ground when off rail!
Who made the wrong Network Id? (TNT)
Implements @yescallop rails

* Rearrange

* Revert

* Removed boolean that i forget to remove

* Working on Powered Rails

Detector rail should detect minecarts.
Code format.
Events for Vehicle
Fixed weird riding?
Still WIP

* Some addons

Minecart will fall down
Fixed Minecart items drops
Powered rail might fixed

* Unique update!

Added Interaction features
Added flying features
A permanent fix for glitch minecarts
Block powered rail can flow
Enum class for Minecart variants
Fix weird riding experience
Fix minecart placement
Fix Mine-TNT not exploding after load world
Now you can play with events
Rewrite Entity class
Renamed fields to suitable name
Rewrite Minecart movement code

* Rewrite riding position

The last events in this class

* Powered Rails now works very well

Fixed rolling amplitude
Riding position rewrite (Not tested yet)
Interaction will interact much better

* Fixes rider position, and minecart hit

* Final upload

Fix false rail orientation
Fix minecart yaw
Moved mount entity into vehicle
Boats now working 👍

* Fix powered rail

* Update BlockRailActivator.java

* Fixed typo, nonstandard naming, removed redundant codes in Minecart Update (Nukkit#1829)

* Fixed typo, nonstandard naming, removed redundant codes

* Revert: A couple of vehicle events

* Add a construct override for Config (Nukkit#1860)

* Fixed PlayerInventory#setArmorContents (Nukkit#1862)

* Added capability to unblock addresses without a restart (Nukkit#1863)

* Update PardonIpCommand.java

* Final, need testing

* Update SessionManager.java

* Fix motion leak (Nukkit#1855)

* Fix motion leak

* hmm

* huh

* Okay last piece

* Making this thing more sense

* Fix Nukkit#1802 (Nukkit#1804)

* Fixed duplicate dropped item (Nukkit#1823)

It's useless to send 2 times the TakeItemEntityPacket, because it is already sending it to every viewers of the entity which is the dropped item.

* repair the problem that command.isRegistered always false (Nukkit#1832)

* Add Yivesmirror to README.md. Close Nukkit#1876

* improvements (Nukkit#1834)

* improvements

* add returns to setters, stairs collision

* fast fix for crafting (Nukkit#1882)

* final fix for crafting (Nukkit#1884)

* fixed crafting with classic UI

* Final fix

* Fixed entities a bit (Nukkit#1892)

* Fix issue when attempt to register block entity by plugin (Nukkit#1897)

* Make Angle region independent (Nukkit#1896)

* Allows for the log level to be changed (Nukkit#1908) Close Nukkit#1869

* Update README.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Revert "Fix for issue Nukkit#1817 -- main thread stuck (rollback Zlib)" (Nukkit#1851)

* Fixed mistake made in commit 410e127 (Nukkit#1923)

* Update to version 1.2 (Nukkit#1912)

* Added tripwire hook, hopper, redstone mechanics saving, various improvements

* recipes

* its not necessary

* Fixed cocoa beans

* Fixed growing

* blame refactor

* Ops

* Fixed some player IDs

* Fixed chunk loading, getSafeSpawn()

* Players shouldn't pass through carpets

* remove debug

* Some vanilla features (eating, breaking sounds)

* add Event for pressureplates

* add chest sounds

* Fix crash

* improvements

* update

* update

* update

* add returns to setters, stairs collision

* Update to 1.2 (Part 1)

* Clean up byte castings in inventory packets

* Join crash fixed. Chunks still corrupted (#44)

* Some new StartGamePacket fields

* Some new packets

ModalForm is the coolest one, I think :D

* It seems that chunk light should not send

* Do not send BlockLight

* Do not send blockLight

* Do not send light

* Packets cleanup and fix

* Revert local world breaking changes

* Fix corrupted chunks

* Bump protocol version to 131

* Some protocol changes

* Fix player's no gravity

* hm hm hm

* Fix being unable to show ModalForms (#49)

* new blocks, fixed boat (#48)

* Fix stained glass pane (#51)

* Small block fix (#53)

* New Updates from pmmp (#52)

* New Updates from pmmp

pmmp/PocketMine-MP@3ad1b1b

* packets

* blockentity

* invetory

* ModalForms API (#54)

Create them with player.showFormWindow, and then listen to the result with PlayerFormRespondedEvent

* It should return windows id (#55)

* Opraven crafting atd..

* Fix #57 - Commands show now (Nukkit#63)

* Fix #57 - Commands show now

* Fix build

* Fix Interact/BlockPlace/Break Events not being called (Nukkit#64)

* Fix #59 - InteractEvent now working

(BlockBreak and BlockPlace still work for me even without changes)

* Fix build

* Fix wrong values

* There was not any error

* ops

* inventory size

* fixed form windows a bit

* let's make it protected

* Use Gson parsing

* crafting fix

* ops

* fixed update block packet

* wtf

* some fixes

* rewrote transaction packet handling (from PMMP)

* Fixed inventory

* fixed update block packet! (idk how :D )

* fixed buttons image, formatting

* fix example config

* fix example config

* fix item dropping

* some improvements from PMMP

* fixed entity IDs

* more adventure settings

* Merge remote-tracking branch 'remotes/origin/master1.2' into GT1.2

# Conflicts:
#	src/main/java/cn/nukkit/Player.java
#	src/main/java/cn/nukkit/inventory/CraftingManager.java
#	src/main/java/cn/nukkit/inventory/PlayerInventory.java
#	src/main/java/cn/nukkit/math/Angle.java
#	src/main/java/cn/nukkit/network/protocol/ProtocolInfo.java
#	src/main/java/cn/nukkit/utils/Utils.java

* Fix Floating Text Particle

* still crashes

* random fixes and additions from PMMP

* Small fix of String.equals in ElementButtonImageData.

* Maybe fix Joining server crashed and "Disconnecting from Server"

* Oops..

* Improved brewing and added fuel

* Ops

* Add fuel to spawn nbt

* Support PlayerSettings FormWindow

* Fix Projectile Items.

* Broadcast LevelSoundEventPacket, More sounds!

* Add PlayerBlockPickEvent + eating sounds

* Fix splash potion type

* Better method

* Repair BossBar, add old title methods for better compatibility (#19)

* Make old plugins working on this Nukkit

* Forgot these imports

* Who did invent this?

* Back to how this should be

* Forgot this

* add fortune

* Fixed sounds, signs, block picking

* New DummyBossBar API! And it's compatible with the old API.

* Oops...

* fixed items with compound tag, added client side anvil support

* Client-side enchant support, need add some API

* maybe better than nothing

* Fixed upload/download updating

* Default no cape in a new Skin, fix NPE in PlayerListPacket (NPC).

* Fix Crafting, ArgTypes + ProtocolVersion (#24)

* Fix NPE

* Fix Arg types

* Change byte to int type

Because byte can handle values from -127 to 127, so we need now something bigger.

* Update it for MCPE 1.2.1

* Debug crafting

* Revert Debug

* Hmm

* Ignore check for Crafting

* Fix build

* Arrrrrgh

* Do pr... se mnou

* Step forward

* Do not check items

* Remove items from where they are

* Remove this debug

* set chunk changed

* small changes

* Big crafting is still buggy,

* add Server settings request event

* ops

* Fix Nukkit sometimes getting wrong Recipe ID (#28)

* Make getResultByOutput working

* Ban this from happening

* Kind of backup here

* Fix

* Debug

* Hm

* Remove it

* Add possibility to write books (#29)

* Add Book & Quill + WrittenBook

Book & Quill and the whole writing of books are TODO

* Create ItemBookWritten.java

* Better have ItemBookWritten than ItemWrittenBook

* More constructors

* Add getPages method

* Load creative items from json

* fix

* Fixed client-side item movement handling

* EaseCation.net

* Careless? Multiple equipItem and call event two times.

* Fix AdventureSettings not works! WFT we forgot reset() (put packet ID!!!!!!)

* Remove old messageQueue, add player.sendChat()

* Changed ArrayList to List

* Allow plugins to change players view distance

* Fixed stained glass pane

* Fixed teleport during process movement

* Fixed double chest inventory

* Update version

* don't pickup items in spectator mode

* reverted eating sounds

* Support Damage Absorption!

* Funny😂, add Player.showXboxProfile

* Fixed flowerpot item conversion

* Fix some logical error in ElementSlider.

* Fix no sound when opening ender chest.

* Fix no any sounds when closing an ender chest.

* Daily enhancement on form (GUI) system 2017/10/13

* FormWindow interpret: This variable is used for JSON import operations. Do NOT delete :) -- @Snake1999

* Don't forget reset() in DataPacket#encode

* Change EntityInteractable from extends to interface.

* Move EntityVehicle#collidingWith to interface to solve the problem of some custom entities.

* AdventureSettingsPacket show broadcast, fix setAllowModifyWorld.

* Fix Take Item animation

* Fix title upgrade of Dummy boss bar

* Use method for entity IDs

* Fixed sleeping bugs and optimized the bed's notices.

* Restoring the DummyBossBar Entity is visible

* use String::isEmpty()

* Fixed item sending in in double chest inventory

* Add serverId in UnconnectedPong Packet

* Added jukebox

* Make it public

* Full Pong result information: MOTD, Sub MOTD and default gamemode.
But... But they do not seem to work... Let it go :D

* Fixed PlaySoundPacket, temporarily removed music discs

* Strange careless of showXboxProfile

* Teleport with pitch.

* Support fast equip armor by right click on hand

* Improved ClientChainData

* Fixed armor equip

* The xbox info will be show in the player list.

* Fixed some incorrect command messages.

* A hack to solve the client-side teleporting bug! (inside into the block)

* Init the server sub-motd.

* If the player is a spectator, when received InventoryTransferPacket, we need calling events with canceled instead of breaking;

* Fix Logging (#45)
Creeperface01 added a commit that referenced this issue Nov 28, 2017
* Added tripwire hook, hopper, redstone mechanics saving, various improvements

* recipes

* its not necessary

* Fixed cocoa beans

* Fixed growing

* blame refactor

* Ops

* Fixed some player IDs

* Fixed chunk loading, getSafeSpawn()

* Players shouldn't pass through carpets

* remove debug

* Some vanilla features (eating, breaking sounds)

* add Event for pressureplates

* add chest sounds

* Fix crash

* improvements

* update

* update

* update

* add returns to setters, stairs collision

* Update to 1.2 (Part 1)

* Clean up byte castings in inventory packets

* Join crash fixed. Chunks still corrupted (#44)

* Some new StartGamePacket fields

* Some new packets

ModalForm is the coolest one, I think :D

* It seems that chunk light should not send

* Do not send BlockLight

* Do not send blockLight

* Do not send light

* Packets cleanup and fix

* Revert local world breaking changes

* Fix corrupted chunks

* Bump protocol version to 131

* Some protocol changes

* Fix player's no gravity

* hm hm hm

* Fix being unable to show ModalForms (#49)

* new blocks, fixed boat (#48)

* Fix stained glass pane (#51)

* Small block fix (#53)

* New Updates from pmmp (#52)

* New Updates from pmmp

pmmp/PocketMine-MP@3ad1b1b

* packets

* blockentity

* invetory

* ModalForms API (#54)

Create them with player.showFormWindow, and then listen to the result with PlayerFormRespondedEvent

* It should return windows id (#55)

* Opraven crafting atd..

* Fix #57 - Commands show now (Nukkit#63)

* Fix #57 - Commands show now

* Fix build

* Fix Interact/BlockPlace/Break Events not being called (Nukkit#64)

* Fix #59 - InteractEvent now working

(BlockBreak and BlockPlace still work for me even without changes)

* Fix build

* Fix wrong values

* There was not any error

* ops

* inventory size

* fixed form windows a bit

* let's make it protected

* Use Gson parsing

* crafting fix

* ops

* fixed update block packet

* wtf

* some fixes

* rewrote transaction packet handling (from PMMP)

* Fixed inventory

* fixed update block packet! (idk how :D )

* fixed buttons image, formatting

* fix example config

* fix example config

* fix item dropping

* some improvements from PMMP

* fixed entity IDs

* more adventure settings

* Merge remote-tracking branch 'remotes/origin/master1.2' into GT1.2

# Conflicts:
#	src/main/java/cn/nukkit/Player.java
#	src/main/java/cn/nukkit/inventory/CraftingManager.java
#	src/main/java/cn/nukkit/inventory/PlayerInventory.java
#	src/main/java/cn/nukkit/math/Angle.java
#	src/main/java/cn/nukkit/network/protocol/ProtocolInfo.java
#	src/main/java/cn/nukkit/utils/Utils.java

* Fix Floating Text Particle

* still crashes

* random fixes and additions from PMMP

* Small fix of String.equals in ElementButtonImageData.

* Maybe fix Joining server crashed and "Disconnecting from Server"

* Oops..

* Improved brewing and added fuel

* Ops

* Add fuel to spawn nbt

* Support PlayerSettings FormWindow

* Fix Projectile Items.

* Broadcast LevelSoundEventPacket, More sounds!

* Add PlayerBlockPickEvent + eating sounds

* Fix splash potion type

* Better method

* Repair BossBar, add old title methods for better compatibility (#19)

* Make old plugins working on this Nukkit

* Forgot these imports

* Who did invent this?

* Back to how this should be

* Forgot this

* add fortune

* Fixed sounds, signs, block picking

* New DummyBossBar API! And it's compatible with the old API.

* Oops...

* fixed items with compound tag, added client side anvil support

* Client-side enchant support, need add some API

* maybe better than nothing

* Fixed upload/download updating

* Default no cape in a new Skin, fix NPE in PlayerListPacket (NPC).

* Fix Crafting, ArgTypes + ProtocolVersion (#24)

* Fix NPE

* Fix Arg types

* Change byte to int type

Because byte can handle values from -127 to 127, so we need now something bigger.

* Update it for MCPE 1.2.1

* Debug crafting

* Revert Debug

* Hmm

* Ignore check for Crafting

* Fix build

* Arrrrrgh

* Do pr... se mnou

* Step forward

* Do not check items

* Remove items from where they are

* Remove this debug

* set chunk changed

* small changes

* Big crafting is still buggy,

* add Server settings request event

* ops

* Fix Nukkit sometimes getting wrong Recipe ID (#28)

* Make getResultByOutput working

* Ban this from happening

* Kind of backup here

* Fix

* Debug

* Hm

* Remove it

* Add possibility to write books (#29)

* Add Book & Quill + WrittenBook

Book & Quill and the whole writing of books are TODO

* Create ItemBookWritten.java

* Better have ItemBookWritten than ItemWrittenBook

* More constructors

* Add getPages method

* Load creative items from json

* fix

* Fixed client-side item movement handling

* EaseCation.net

* Careless? Multiple equipItem and call event two times.

* Fix AdventureSettings not works! WFT we forgot reset() (put packet ID!!!!!!)

* Remove old messageQueue, add player.sendChat()

* Changed ArrayList to List

* Allow plugins to change players view distance

* Fixed stained glass pane

* Fixed teleport during process movement

* Fixed double chest inventory

* Update version

* don't pickup items in spectator mode

* reverted eating sounds

* Support Damage Absorption!

* Funny😂, add Player.showXboxProfile

* Fixed flowerpot item conversion

* Fix some logical error in ElementSlider.

* Fix no sound when opening ender chest.

* Fix no any sounds when closing an ender chest.

* Daily enhancement on form (GUI) system 2017/10/13

* FormWindow interpret: This variable is used for JSON import operations. Do NOT delete :) -- @Snake1999

* Don't forget reset() in DataPacket#encode

* Change EntityInteractable from extends to interface.

* Move EntityVehicle#collidingWith to interface to solve the problem of some custom entities.

* AdventureSettingsPacket show broadcast, fix setAllowModifyWorld.

* Fix Take Item animation

* Fix title upgrade of Dummy boss bar

* Use method for entity IDs

* Fixed sleeping bugs and optimized the bed's notices.

* Restoring the DummyBossBar Entity is visible

* use String::isEmpty()

* Fixed item sending in in double chest inventory

* Add serverId in UnconnectedPong Packet

* Added jukebox

* Make it public

* Full Pong result information: MOTD, Sub MOTD and default gamemode.
But... But they do not seem to work... Let it go :D

* Fixed PlaySoundPacket, temporarily removed music discs

* Strange careless of showXboxProfile

* Teleport with pitch.

* Support fast equip armor by right click on hand

* Improved ClientChainData

* Fixed armor equip

* The xbox info will be show in the player list.

* Fixed some incorrect command messages.

* A hack to solve the client-side teleporting bug! (inside into the block)

* Init the server sub-motd.

* If the player is a spectator, when received InventoryTransferPacket, we need calling events with canceled instead of breaking;

* Fix Logging (#45)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant