Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw value support #30

Open
ethanfrey opened this issue Aug 18, 2021 · 0 comments
Open

Add raw value support #30

ethanfrey opened this issue Aug 18, 2021 · 0 comments

Comments

@ethanfrey
Copy link
Member

ethanfrey commented Aug 18, 2021

This is an interesting type from serde-json: https://docs.serde.rs/serde_json/value/struct.RawValue.html

It would be cool to support it, but no idea how much work it would be. This would let us actually embed json objects in other objects and not base64 encoded them (Binary) when embedding them, making a much nicer API for messages containing messages, like cw20 send.

To do it efficiently, it would also require us to remove the 'static constraints on from_slice and use an arbitrary lifetime 'a. (Until now we only support owned data)

The implementation seems a bit magic to me and does seem to require visit_map to be implemented... https://docs.serde.rs/src/serde_json/raw.rs.html#291-319 which probably would fail out of the box.

aumetra pushed a commit that referenced this issue Jul 26, 2024
…escaped-strings

Correctly handle escaped strings when parsing json strings. Fixes #30 & #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant