We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Following #769, this issue is to support 1559 in private transactions via eea_sendTransaction.
Draft PR already underway: #838 #950
A web3j bug was found which prevented EIP-1559 from being decoded which is why this issue was split out: https://github.com/web3j/web3j/blob/2ad9a8b4b9411de13c6d09e8392a51213d8160f0/eea/src/main/java/org/web3j/protocol/eea/crypto/PrivateTransactionDecoder.java#L35-L39 Although the delegation to TransactionDecoder.decode() covers the 1559 decoding routine, the RlpDecoder.decode() method higher up relies on the all important stripping of the first byte happening before it is called... final byte[] encodedTx = Arrays.copyOfRange(transaction, 1, transaction.length);
The text was updated successfully, but these errors were encountered:
Blocked on changes in web3j to support encoding of EIP-1559 private transactions
Sorry, something went wrong.
Web3j issue has been filed for this hyperledger-web3j/web3j#1966
PR for Web3j private 1559 transaction - hyperledger-web3j/web3j#1980
hyperledger-web3j/web3j#1980 merged, no longer blocked.
Latest PR is #950
No branches or pull requests
Following #769, this issue is to support 1559 in private transactions via eea_sendTransaction.
Draft PR already underway:
#838#950A web3j bug was found which prevented EIP-1559 from being decoded which is why this issue was split out:
https://github.com/web3j/web3j/blob/2ad9a8b4b9411de13c6d09e8392a51213d8160f0/eea/src/main/java/org/web3j/protocol/eea/crypto/PrivateTransactionDecoder.java#L35-L39
Although the delegation to TransactionDecoder.decode() covers the 1559 decoding routine, the RlpDecoder.decode() method higher up relies on the all important stripping of the first byte happening before it is called...
final byte[] encodedTx = Arrays.copyOfRange(transaction, 1, transaction.length);
Tasks
The text was updated successfully, but these errors were encountered: